Mercurial 3.6 compatibility for pushlog

RESOLVED FIXED

Status

Developer Services
Mercurial: Pushlog
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
There are some test failures with the pushlog extension on Mercurial 3.6RC. Looks like we'll need to perform a little porting.
(Assignee)

Comment 1

2 years ago
Created attachment 8677937 [details]
MozReview Request: pushlog: optionally perform dockeywords manipulation (bug 1217569); r?smacleod

pushlog: optionally perform dockeywords manipulation (bug 1217569); r?smacleod

dockeywords was removed in Mercurial 3.6 and the behavior is automatic
if the regular keywords dict is updated.
Attachment #8677937 - Flags: review?(smacleod)
(Assignee)

Comment 2

2 years ago
Created attachment 8677938 [details]
MozReview Request: pushlog: don't use weakref to repo (bug 1217569); r?smacleod

pushlog: don't use weakref to repo (bug 1217569); r?smacleod

The old behavior won't work in Mercurial 3.6 because of
https://bz.mercurial-scm.org/show_bug.cgi?id=4915.

This is arguably a bug in Mercurial. However, looking at the Mercurial
code, relying on the same exact object for the repo is kinda difficult,
as filters are involved and these create new repo instances.

This commit removes the weakref. It also stops caching the pushlog
instance on the repo. There is no state on the instance and recreating
it is cheap. We arguably should have been doing this all along.

Since this was the last piece of pushlog that didn't work with 3.6, I
bumped the testwith property to indicate 3.6 compatibility.
Attachment #8677938 - Flags: review?(smacleod)
Attachment #8677937 - Flags: review?(smacleod) → review+
Comment on attachment 8677937 [details]
MozReview Request: pushlog: optionally perform dockeywords manipulation (bug 1217569); r?smacleod

https://reviewboard.mozilla.org/r/23057/#review20571
Comment on attachment 8677938 [details]
MozReview Request: pushlog: don't use weakref to repo (bug 1217569); r?smacleod

https://reviewboard.mozilla.org/r/23059/#review20573
Attachment #8677938 - Flags: review?(smacleod) → review+
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/4246ddb54f526958e1cfa40a0d4c6dff8882e9a3
pushlog: optionally perform dockeywords manipulation (bug 1217569); r=smacleod

https://hg.mozilla.org/hgcustom/version-control-tools/rev/fd8f2df5ffe1cf043a7ae51f26672a749a595b0e
pushlog: don't use weakref to repo (bug 1217569); r=smacleod
(Assignee)

Comment 6

2 years ago
Deployed.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.