Closed Bug 1217614 Opened 4 years ago Closed 4 years ago

IsCallerChrome crash in DataTransfer::MozGetDataAt

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files, 1 obsolete file)

https://crash-stats.mozilla.com/report/index/c5d7c580-657b-4eb2-acfa-bf40c2151021

nsContentUtils::SubjectPrincipal() 	dom/base/nsContentUtils.cpp
mozilla::dom::DataTransfer::MozGetDataAt(nsAString_internal const&, unsigned int, nsIVariant**) 	dom/events/DataTransfer.cpp
nsPlaintextEditor::InsertFromDataTransfer(mozilla::dom::DataTransfer*, int, nsIDOMDocument*, nsIDOMNode*, int, bool) 	editor/libeditor/nsPlaintextDataTransfer.cpp
nsPlaintextEditor::InsertFromDrop(nsIDOMEvent*) 	editor/libeditor/nsPlaintextDataTransfer.cpp
nsEditorEventListener::Drop(nsIDOMDragEvent*) 	editor/libeditor/nsEditorEventListener.cpp
xul.dll 	nsEditorEventListener::HandleEvent(nsIDOMEvent*) 	editor/libeditor/nsEditorEventListener.cpp
This one was kinda gross.
Attachment #8677768 - Flags: review?(bzbarsky)
Comment on attachment 8677767 [details] [diff] [review]
Part 1 - Remove XPIDL mozSetDataAt and refactor associated code. v1

r=me
Attachment #8677767 - Flags: review?(bzbarsky) → review+
Comment on attachment 8677768 [details] [diff] [review]
Part 2 - Remove nsIDOMDataTransfer::mozGetDataAt and refactor associated code. v1

r=me
Attachment #8677768 - Flags: review?(bzbarsky) → review+
Needed to remove the XPIDL SetData as well, since it's called the WebIDL-y
clipboard API and needs to have the subject principal of script.
Attachment #8678396 - Flags: review?(bzbarsky)
Attachment #8677767 - Attachment is obsolete: true
Comment on attachment 8678396 [details] [diff] [review]
Part 1 - Remove XPIDL mozSetDataAt and refactor associated code. v2

r=me
Attachment #8678396 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/6afe058f809e
https://hg.mozilla.org/mozilla-central/rev/3c28f231b55f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.