Build fails if one more file is add to UNIFIED_SOURCES at netwerk/base/moz.build

RESOLVED FIXED in Firefox 44

Status

()

Core
Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: yury, Assigned: yury)

Tracking

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
If I add one more file before 'nsURIChecker.cpp' (e.g. https://pastebin.mozilla.org/8850177) build fails with:

 1:01.90 In file included from /Users/yury/Work/obj-ff-nightly/netwerk/base/Unified_cpp_netwerk_base4.cpp:2:
 1:01.90 /Users/yury/Work/mozilla-central/netwerk/base/nsURIChecker.cpp:156:17: error: member access into incomplete type 'nsIURI'
 1:01.90             aURI->SchemeIs("http", &isReallyHTTP);
 1:01.90                 ^
 1:01.90 ../../dist/include/nsIURIChecker.h:17:7: note: forward declaration of 'nsIURI'
 1:01.90 class nsIURI; /* forward declaration */
 1:01.90       ^
 1:01.90 In file included from /Users/yury/Work/obj-ff-nightly/netwerk/base/Unified_cpp_netwerk_base4.cpp:2:
 1:01.90 /Users/yury/Work/mozilla-central/netwerk/base/nsURIChecker.cpp:158:21: error: member access into incomplete type 'nsIURI'
 1:01.90                 aURI->SchemeIs("https", &isReallyHTTP);
 1:01.90                     ^
 1:01.90 ../../dist/include/nsIURIChecker.h:17:7: note: forward declaration of 'nsIURI'
 1:01.90 class nsIURI; /* forward declaration */
 

nsURIChecker.cpp/.h does not include nsIURI.h, so depends on other cpp files to include it -- it was nsSimpleURI.cpp while nsURIChecker.cpp was in Unified_cpp_netwerk_base3 group.
(Assignee)

Updated

2 years ago
Summary: Build failes if one more file is add to UNIFIED_SOURCE at netwerk/base/moz.build → Build fails if one more file is add to UNIFIED_SOURCES at netwerk/base/moz.build
(Assignee)

Comment 1

2 years ago
Created attachment 8677743 [details] [diff] [review]
Fixes nsURIChecker.cpp dependency on nsIURI.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c8228cab4e8
(Assignee)

Updated

2 years ago
Component: Build Config → Networking
(Assignee)

Updated

2 years ago
Attachment #8677743 - Flags: review?(mcmanus)
Comment on attachment 8677743 [details] [diff] [review]
Fixes nsURIChecker.cpp dependency on nsIURI.

Review of attachment 8677743 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8677743 - Flags: review?(mcmanus) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → ydelendik
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Blocks: 1218029

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f008f766a0cc
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f008f766a0cc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Depends on: 1218779
No longer depends on: 1218779
You need to log in before you can comment on or make changes to this bug.