Closed Bug 1217617 Opened 8 years ago Closed 8 years ago

Build fails if one more file is add to UNIFIED_SOURCES at netwerk/base/moz.build

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: yury, Assigned: yury)

References

Details

Attachments

(1 file)

Fixes nsURIChecker.cpp dependency on nsIURI.
1.03 KB, patch
mcmanus
: review+
Details | Diff | Splinter Review 
If I add one more file before 'nsURIChecker.cpp' (e.g. https://pastebin.mozilla.org/8850177) build fails with:

 1:01.90 In file included from /Users/yury/Work/obj-ff-nightly/netwerk/base/Unified_cpp_netwerk_base4.cpp:2:
 1:01.90 /Users/yury/Work/mozilla-central/netwerk/base/nsURIChecker.cpp:156:17: error: member access into incomplete type 'nsIURI'
 1:01.90             aURI->SchemeIs("http", &isReallyHTTP);
 1:01.90                 ^
 1:01.90 ../../dist/include/nsIURIChecker.h:17:7: note: forward declaration of 'nsIURI'
 1:01.90 class nsIURI; /* forward declaration */
 1:01.90       ^
 1:01.90 In file included from /Users/yury/Work/obj-ff-nightly/netwerk/base/Unified_cpp_netwerk_base4.cpp:2:
 1:01.90 /Users/yury/Work/mozilla-central/netwerk/base/nsURIChecker.cpp:158:21: error: member access into incomplete type 'nsIURI'
 1:01.90                 aURI->SchemeIs("https", &isReallyHTTP);
 1:01.90                     ^
 1:01.90 ../../dist/include/nsIURIChecker.h:17:7: note: forward declaration of 'nsIURI'
 1:01.90 class nsIURI; /* forward declaration */
 

nsURIChecker.cpp/.h does not include nsIURI.h, so depends on other cpp files to include it -- it was nsSimpleURI.cpp while nsURIChecker.cpp was in Unified_cpp_netwerk_base3 group.
Summary: Build failes if one more file is add to UNIFIED_SOURCE at netwerk/base/moz.build → Build fails if one more file is add to UNIFIED_SOURCES at netwerk/base/moz.build
Component: Build Config → Networking
Attachment #8677743 - Flags: review?(mcmanus)
Comment on attachment 8677743 [details] [diff] [review]
Fixes nsURIChecker.cpp dependency on nsIURI.

Review of attachment 8677743 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8677743 - Flags: review?(mcmanus) → review+
Assignee: nobody → ydelendik
Keywords: checkin-needed
Blocks: 1218029
https://hg.mozilla.org/mozilla-central/rev/f008f766a0cc
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
No longer depends on: 1218779
You need to log in before you can comment on or make changes to this bug.