Closed Bug 1217621 Opened 4 years ago Closed 4 years ago

Show settings action for XUL notifications

Categories

(Toolkit :: Notifications and Alerts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: Lina, Assigned: Lina)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Comment on attachment 8677736 [details] [diff] [review]
0001-Bug-1217621-Show-settings-action-for-XUL-notificatio.patch

Review of attachment 8677736 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a test for this. You can refer to /browser/base/content/test/alerts/browser_notification_close.js for an example. Please use the add_task approach seen in the *_close.js test, but *_do_not_disturb.js shows an example of opening the menu and clicking on a menuitem.
Attachment #8677736 - Flags: review?(jaws)
PTAL. I didn't see `browser_notification_close.js`, but I borrowed from the existing settings and do not disturb tests.
Attachment #8677736 - Attachment is obsolete: true
Attachment #8678292 - Flags: review?(jaws)
Comment on attachment 8678292 [details] [diff] [review]
0001-Bug-1217621-Show-settings-action-for-XUL-notificatio.patch

Review of attachment 8678292 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks good.
Attachment #8678292 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/04d81b3992f6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.