Closed
Bug 1217712
Opened 7 years ago
Closed 7 years ago
[Presentation WebAPI] gecko handling for presentation-receiver-permission-denied event
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: schien, Assigned: schien)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker])
Attachments
(2 files, 2 obsolete files)
8.01 KB,
patch
|
selin
:
review+
|
Details | Diff | Splinter Review |
6.69 KB,
patch
|
schien
:
review+
|
Details | Diff | Splinter Review |
This bug is for gecko part of bug 1202542. Gecko need to handle presentation-receiver-permission-denied event and reject the remote presentation request.
Assignee | ||
Comment 1•7 years ago
|
||
Gaia will send mozPresentationContentEvent(type:presentation-receiver-permission-denied) to reject launching packaged app without 'presentation' permission.
Attachment #8677892 -
Flags: review?(selin)
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8677892 [details] [diff] [review] [part 1] bug1202542-reject-app-no-permission.patch patch generation issue. will provide a correct patch in next upload.
Attachment #8677892 -
Attachment is obsolete: true
Attachment #8677892 -
Flags: review?(selin)
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8a3d1ed01e0
Assignee | ||
Comment 4•7 years ago
|
||
Gaia will send mozPresentationContentEvent(type:presentation-receiver-permission-denied) to reject launching packaged app without 'presentation' permission.
Attachment #8677900 -
Flags: review?(selin)
Assignee | ||
Comment 5•7 years ago
|
||
Found this bug during integration test. Control channel might be closed without error message. This fix can improve our error handling.
Attachment #8677902 -
Flags: review?(selin)
Comment 6•7 years ago
|
||
Comment on attachment 8677900 [details] [diff] [review] [part 1] bug1202542-reject-app-no-permission.patch Review of attachment 8677900 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/components/test/mochitest/presentation_ui_glue_handler_chrome.js @@ +21,5 @@ > addMessageListener('trigger-ui-glue', function(aData) { > var promise = glue.sendRequest(aData.url, aData.sessionId); > promise.then(function(aFrame){ > sendAsyncMessage('iframe-resolved', aFrame); > + }).catch(function(){ nit: add one space before "{".
Attachment #8677900 -
Flags: review?(selin) → review+
Comment 7•7 years ago
|
||
Comment on attachment 8677902 [details] [diff] [review] [part 2] handle-close-no-reason.patch Review of attachment 8677902 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8677902 -
Flags: review?(selin) → review+
Assignee | ||
Comment 8•7 years ago
|
||
update according to review comment, carry r+.
Attachment #8677900 -
Attachment is obsolete: true
Attachment #8678180 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c109c8df8eb https://hg.mozilla.org/integration/mozilla-inbound/rev/11b00fe66b65
Keywords: checkin-needed
Updated•7 years ago
|
Whiteboard: [ft:conndevices][partner-blocker]
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7c109c8df8eb https://hg.mozilla.org/mozilla-central/rev/11b00fe66b65
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•