Closed Bug 1217714 Opened 4 years ago Closed 4 years ago

Remove some unused functions from MediaDecoderReader

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

There are some functions that can be removed from MediaDecoderReader or moved down to sub-classes for they are not accessed from the interface of MediaDecoderReader.
Bug 1217714 - Remove some unused functions from MediaDecoderReader. r=jya.
Attachment #8678650 - Flags: review?(jyavenard)
Assignee: nobody → jwwang
Comment on attachment 8678650 [details]
MozReview Request: Bug 1217714 - Remove some unused functions from MediaDecoderReader. r=jya.

https://reviewboard.mozilla.org/r/23215/#review20693

::: dom/media/MediaFormatReader.cpp:1547
(Diff revision 1)
>    if (aLength || aOffset) {

This whole block can now be removed as only NotifyDataArrived path will now be used. So keeping only mDemuxer->NotifyDataArrived

::: dom/media/omx/MediaCodecReader.h:181
(Diff revision 1)
> +  virtual bool HasAudio();

override keyword

::: dom/media/omx/MediaOmxReader.h:111
(Diff revision 1)
> +  virtual bool HasAudio() { return mHasAudio; }

override

::: dom/media/webm/WebMReader.h:73
(Diff revision 1)
> +  AbstractMediaDecoder* GetDecoder()

does this need to be public?
Attachment #8678650 - Flags: review?(jyavenard) → review+
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/8d3d0a2c6bbc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.