1217714 - Remove some unused functions from MediaDecoderReader

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

There are some functions that can be removed from MediaDecoderReader or moved down to sub-classes for they are not accessed from the interface of MediaDecoderReader.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1217714 - Remove some unused functions from MediaDecoderReader. r=jya.

Bug 1217714 - Remove some unused functions from MediaDecoderReader. r=jya.

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8678650 [details]
MozReview Request: Bug 1217714 - Remove some unused functions from MediaDecoderReader. r=jya.

https://reviewboard.mozilla.org/r/23215/#review20693

::: dom/media/MediaFormatReader.cpp:1547
(Diff revision 1)
>    if (aLength || aOffset) {

This whole block can now be removed as only NotifyDataArrived path will now be used. So keeping only mDemuxer->NotifyDataArrived

::: dom/media/omx/MediaCodecReader.h:181
(Diff revision 1)
> +  virtual bool HasAudio();

override keyword

::: dom/media/omx/MediaOmxReader.h:111
(Diff revision 1)
> +  virtual bool HasAudio() { return mHasAudio; }

override

::: dom/media/webm/WebMReader.h:73
(Diff revision 1)
> +  AbstractMediaDecoder* GetDecoder()

does this need to be public?

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/23215/#review20693

> does this need to be public?

Used by https://hg.mozilla.org/mozilla-central/file/d53a52b39a95/dom/media/webm/SoftwareWebMVideoDecoder.cpp#l212

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d3d0a2c6bbc

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8d3d0a2c6bbc