Closed Bug 121774 Opened 23 years ago Closed 14 years ago

<popupset> is deprecated, you can put your context menu popups all by themselves.

Categories

(Other Applications :: DOM Inspector, defect)

Product:
Other Applications
Component:
DOM Inspector
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: timeless, Unassigned)

References

(
URL
)

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 3 obsolete files)

v1.2
51.51 KB, patch
Details | Diff | Splinter Review
Status: NEW → ASSIGNED
Target Milestone: --- → Future
The deprecation of popupset shouldn't seriously affect performance or operation
of DOM Inspector.  If you desire, you can assign this bug to me.
Severity: normal → trivial
I'll take this.
Assignee: hewitt → ajvincent
Status: ASSIGNED → NEW
Blocks: 70752
Product: Core → Other Applications
Reassigning DOM-I bugs which have stagnated in my buglist back to default owner.  Hopefully someone will pick up some of these bugs and work on them.  I'll continue to follow them.
Assignee: ajvincent → dom-inspector
Target Milestone: Future → ---
OS: Windows 2000 → All
Hardware: PC → All
Attached patch v1.0 (obsolete) — — Splinter Review 
Seems to work for me, but I'd like someone else to test this before I request review.
Assignee: dom-inspector → comrade693+bmo
Status: NEW → ASSIGNED
Attachment #246107 - Flags: review?(db48x)
Comment on attachment 246107 [details] [diff] [review]
v1.0

r=db48x
Attachment #246107 - Flags: review?(db48x) → review+
Attachment #246107 - Flags: superreview?(neil)
Comment on attachment 246107 [details] [diff] [review]
v1.0

This doesn't even work, probably because the overlays key off the popupset id.
Attachment #246107 - Flags: superreview?(neil) → superreview-
Attached patch v1.1 (obsolete) — — Splinter Review 
Funny...my build must have lied to me...  This time I did a full clean build (as in bye bye object director, lets start fresh).

Alright, so I did extensive checking this time around, and this should get everything.  I even had to modify a test file that uses inspector code...  From basic playing around, everything seems to work correctly still.

I removed commented out code that I would have had to modify because I was changing id's.
Attachment #246107 - Attachment is obsolete: true
Attachment #248721 - Flags: review?(db48x)
Attached patch v1.1.1 (obsolete) — — Splinter Review 
minor typo broke the styleRules pane
Attachment #248721 - Attachment is obsolete: true
Attachment #248751 - Flags: review?(db48x)
Attachment #248721 - Flags: review?(db48x)
Attachment #248751 - Flags: review?(db48x)
Attached patch v1.2 — — Splinter Review 
Nothing looks busted, and this removes a bunch of search code that's been commented out for who knows how long and cleans up formatting in places.

It should be noted that you need to do a full build when applying this patch because just running make in extensions/inspector doesn't seem to update the changes made in jar.mn (this only applies to Firefox, not Seamonkey I think)
Attachment #248751 - Attachment is obsolete: true
Attachment #249204 - Flags: review?(db48x)
Depends on: 378696
Attachment #249204 - Flags: review?(db48x)
QA Contact: timeless → dom-inspector
Assignee: comrade693+bmo → nobody
Status: ASSIGNED → NEW
Whiteboard: [good first bug]
WONTFIX?
Firefox (Bug 535974) and SeaMonkey (Bug 572682) have moved/are moving all popups, panels, and tooltips into popupsets.
(In reply to comment #11)

Yep.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: