1217755 - [RTL][Dialer]The position of Call out button and Add contact button is not swapped.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect, P4)

Description

[Alissa（leave from Mozilla）]

Attachment: Dialer_call out&add contact.png

[1.Description]:
[RTL][Arieskk_v2.5][Flamekk_v2.5][Dialer]The position of Call out button and Add contact button is not swapped.
See attachment:Dialer_call out&add contact.png

[2.Testing Steps]: 
1. Set your phone language to Arabic and launch Dialer. 
2. Observe the Dial Pad. 

[3.Expected Result]: 
2.The call out button should display left-aligned, and add contact button should display right-aligned.

[4.Actual Result]: 
2.The call out button is right-aligned, and add contact button is left-aligned.

[5.Reproduction build]: 
Device: AriesKK_2.5 [Affected]
Build ID               20151023005002
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151023.001128
Firmware Date          Fri Oct 23 00:11:35 UTC 2015
Bootloader             s1

Device: FlameKK_v2.5[Affected]
Build ID               20151022150207
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/76bd0c01d72e64ca4f261ffdb2652a91f961e930
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151022.185000
Firmware Date          Thu Oct 22 18:50:13 EDT 2015
Base image                              v18d v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15418

Comment 1

[Gabriele Svelto [:gsvelto]]

The entire keyboard container was explicitly set in LTR mode in bug 1211954, this applies to those buttons too. Pierre-Eric should this be changed?

Comment 2

[pelloux]

In my opinion we shouldn't mirror the position of these 2 buttons.
While this isn't covered explicitely by the 2.5 RTL specification, there are other examples of UI not being mirrored: for instance on the lockscreen the unlock action is always on the right.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mermi, can you weigh in please, since you're a native Arabic person?

Comment 4

[Sam Foster [:sfoster] (he/him)]

Fix will land in bug 1217377

Comment 5

[SandKing]

Attachment: Picture: Verify_Fail.png

According bug 1217377 comment 7, the patch of this bug has been landed on v 2.5 and v2.6, But unfortunately, this bug has been verified as fail by STR with comment 0.

See picture:"Verify_Fail.png".
Actual Result: The call out button is right-aligned, and add contact button is left-aligned.

Device: Flame KK 2.5  512mb (Fail)
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master)(Fail)
Build ID               20151109150204
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.182508
Firmware Date          Mon Nov  9 18:25:22 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device:Aries KK V2.5(Fail)
Build ID               20151109233837
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/772f6c235fc48d91efd6346f5b3d8b216eb2dcb1
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151109.225902
Firmware Date          Mon Nov  9 22:59:11 UTC 2015
Bootloader             s1

Device: Aries KK 2.6 (master)(Fail)
Build ID               20151109151826
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151109.143842
Firmware Date          Mon Nov  9 14:38:50 UTC 2015
Bootloader             s1

Comment 6

[William Hsu [:whsu]]

Reopen this bug.
Reasons are as below.
1) The action buttons on the dialer screen is mirrored in the same manner as toolbar icons
2) The toolbar icon sequence is mirrored; as are individual icons that suggest directionality.
   This rule will apply to the in-call screen as well.

Details, please refer to RTL UX spec, page 12.
- https://mozilla.app.box.com/s/y60s1ngyza9jcltmpaqwfoye4f311n5r

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to pierre-eric from comment #2)
> In my opinion we shouldn't mirror the position of these 2 buttons.
> While this isn't covered explicitely by the 2.5 RTL specification, there are
> other examples of UI not being mirrored: for instance on the lockscreen the
> unlock action is always on the right.

We had a long discussion about this in the dev-fxos IIRC. The upshot was that unlock was an exception for ergonomic reasons. This toolbar should be mirrored according to the spec. Marking as a low priority however.