121776 - XMLSerializer loses content

Status: VERIFIED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Bradley Baetz (:bbaetz)]

1. Go to the above url, and look at the attachment.
2. Scroll all the way down, and see what the last line is.
3. Press the "eddit attachment as comment" button
4. Repeat step 2, and note that the attachment is truncated.

I don't think this is a bugzilla bug - the script shouldn't care about the size.
ccing myk anyway, just in case.

I haven't tried making a minimal testcase yet.

Comment 1

[Johnny Stenback (:jst)]

XML serializer bug, over to heikki.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Holy cow! I had no idea were were misuing XMLSerializer in Bugzilla. It is used
to serialize the attachment, which is a Really Bad Idea (TM) when the attachment
is not an XML document. Oh boy...

Anyway, I don't see the problem in Windows or Mac. I am building on Linux, will
test there after it finishes.

Comment 3

[Bradley Baetz (:bbaetz)]

OK, I've tried to reproduce this again, and can't. I'm wondering if I just
pressed the button before the attachment finished loading (I'm on dialup). I'm
sure that I tested that, though (see step 2). Hmm.

If you have a way for us to do this w/o "misusing" xmlserializer, then if you
describe it/rewrite the script, I'll patch bugzilla.

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

WFM too, also on Linux. It is possible that you were seeing a regression caused
by jst's getElementById optimization, which was fixed by harishd.

If/when we get a scriptable HTML serializer (or generalized serializer) I'll let
you know.

Comment 5

[Johnny Stenback (:jst)]

s/getElementById/nsHTMLTags::LookupTag/

Comment 6

[Hixie (not reading bugmail)]

v per comments