1217765 - [TV][2.5] Permission prompt up window broken on TV.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect, P2)

Description

[Josh Cheng [:josh]]

As a user, I want to be prompted if Content wants to access privileged APIs on the FxOS (much like it’s done in the browser today)

Comment 1

[Josh Cheng [:josh]]

Mark as RESOLVED since we already done this in 2.1

Comment 2

[Josh Cheng [:josh]]

We need to fix the layout aspect for the warning page.

Comment 3

[Josh Cheng [:josh]]

Attachment: Screen Shot 2015-10-30 at 2.38.38 PM.png

Attach current layout which should be fix

Comment 4

[Josh Cheng [:josh]]

Hi Evelyn,
Could you help to find someone who can help fixing this? ;)

Comment 5

[Evelyn Hung]

Rex, could you fix this layout in TV System? Thanks.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

ni? UX to make sure it is TV remote friendly

Comment 7

[David Almström]

dont have to do this. I prefer if we dont do this actually. the smoother the better.

Comment 8

[David Almström]

Is it doable? If so, that would be an interesting feature to try out. I know Ben Francis wants to have something similar for pin-the-web

Comment 9

[Tori Chen [:tori]]

Attachment: permission_UI.zip

This seems a UI bug to me so I will fix the broken layout first.
We can discuss new design after we fix the UI.

Hi Peko, the attached are some screenshots and the spec for phone, could you fix the layout for TV? Thanks!

Comment 10

[Peko Chen [:pekochen]]

Attachment: website permission.zip

Hi,

Updated website permission layout.
Please take a look.
Thanks

Comment 11

[Peko Chen [:pekochen]]

Attachment: website permission _0.2.zip

according to Tori's request,add ok button in the second page.

Comment 12

[Tori Chen [:tori]]

Thanks Peko.

Hi Rex, are you the person who help fixing this?

Comment 13

[KM Lee [:rexboy] (inactivate after Sep. 22)]

taken

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:permission-manager-merge > mozilla-b2g:master

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8692476 [details] [review]
[gaia] rexboy7:permission-manager-merge > mozilla-b2g:master

Not easy to fix :-/ for CSS rules are quite different for TV and Phone.
I just make it usable on TV without considering backward-compatible.
Tested with camera/geolocation/mic dialog.

I didn't test other types of window that permission window supports. We may need to open other bugs to fix them if they're being used.
Hi Luke, may you help review this patch?

Comment 16

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692476 [details] [review]
[gaia] rexboy7:permission-manager-merge > mozilla-b2g:master

Please take a look at my comments on GitHub. Thanks.

Comment 17

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8692476 [details] [review]
[gaia] rexboy7:permission-manager-merge > mozilla-b2g:master

Just updated. Thanks for your suggestion.
May you review it again? Changes are in the second commit.

Comment 18

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692476 [details] [review]
[gaia] rexboy7:permission-manager-merge > mozilla-b2g:master

Looks good now. Thanks.

Comment 19

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Merged on master
https://github.com/mozilla-b2g/gaia/commit/4d84a7444c8e73d0e5d8800df04eb2b69174504d

Comment 20

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8692476 [details] [review]
[gaia] rexboy7:permission-manager-merge > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): more like a feature, the permission window hasn't been fixed ever.
[User impact] if declined: permission window can't be controlled on TV.
[Testing completed]:local test ok
[Risk to taking this patch] (and alternatives if risky): small; for it just affect permission window
[String changes made]: none

Comment 21

[Josh Cheng [:josh]]

Comment on attachment 8692476 [details] [review]
[gaia] rexboy7:permission-manager-merge > mozilla-b2g:master

Approve for TV 2.5

Comment 22

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/391bcad1b3b427f189f4c7f11858fc739574682e

Comment 23

[Cynthia Tang [:cynthiatang]]

Hi Rex and Dan,
Could you please check the patch? Is there a way to remove the white block? Thank you.

STR:
 1. Launch Browser
 2. Go to Menu > Select "Sign in to Sync" > Press OK

Actual result
 - There is a white block at the top of the screen
 - Please see the screenshot

Expected result
 - No white block at the top of the screen

=========  Failed  ========================
Commit: 4d84a7444c8e73d0e5d8800df04eb2b69174504d [4d84a74]
Parents: ef452b89c7, ffcab689a9
Author: Rex KM Lee <[e-mail]>
Date: 2015年11月30日 GMT+816:15:41秒

Merge pull request #33386 from rexboy7/permission-manager-merge

Bug 1217765 - [TV][System] Make permission window usable on TV.r=lchang


=========  Passed  ========================
Commit: ef452b89c76e47d27584c15996aa03da2a716531 [ef452b8]
Parents: b04e417b7b, 0d97e848e0
Author: Yi-Fan Liao <[e-mail]>
Date: 2015年11月30日 GMT+816:10:05秒

Merge pull request #33381 from begeeben/1222016_there_should_be_a_pop_up

Bug 1222016 - [TV Browser] There should be a pop-up window if user disconnect successfully, r=ferjm

Comment 24

[Cynthia Tang [:cynthiatang]]

Attachment: screen.png

Comment 25

[Dan Huang[:danhuang]]

Hi Rex, the firefox account sign-in page would also use the css rule: '[role="dialog"].generic-dialog'.
So the change in tv_apps/smart-system/style/themes/default/core.css affect the style of firefox account sign-in page. 
If the change in core.css is for general purpose, I think it's better to update the 'fxa-dialog' css rule for customizing firefox account dialog to fix the issue.

Comment 26

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Let's open another bug for this.