1217781 - [RTL][Contacts]The text within cancel button is not center-aligned in search view.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[Lancy(Leave from Mozilla)]

Attachment: Contacts_Cancel_v2.5.png

[1.Description]:
[RTL][AriesKK v2.5][Contacts]Tap search field in main view of Contacts, the text within cancel button is not center-aligned.
See attachment:Contacts_Cancel_v2.5.png

[2.Testing Steps]: 
1. Have your phone set in a RTL language(Arabic) 
2. Go to the Contacts app.
3.Tap the search filed.

[3.Expected Result]: 
3.The text within cancel button should be center-aligned.

[4.Actual Result]: 
3.The text within cancel button is not center-aligned.

[5.Reproduction build]: 
Device: Flame KK 2.5 build (Unaffected)
Build ID               20151022150207
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/76bd0c01d72e64ca4f261ffdb2652a91f961e930
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151022.185000
Firmware Date          Thu Oct 22 18:50:13 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 build (Affected)
Build ID               20151023005002
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151023.001128
Firmware Date          Fri Oct 23 00:11:35 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
15384

Comment 1

[Augustin Trancart [:autra]]

This is not a search issue. The application Search is about:
- new browser tabs (either private or not)
- the results area when doing a search in the rocketbar.

For in-app searches, the component is the app itself. Thanks!

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1217781-cancel_button_text_position > mozilla-b2g:master

Comment 3

[Augustin Trancart [:autra]]

Comment on attachment 8684245 [details] [review]
[gaia] Phoxygen:bug1217781-cancel_button_text_position > mozilla-b2g:master

This is not a RTL issue in fact (but you can see it better in a locale where the word "cancel" take a small area or if the screen is large).

Francisco, please r? (though it is in shared, not sure if you are the good person for that)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8684245 [details] [review]
[gaia] Phoxygen:bug1217781-cancel_button_text_position > mozilla-b2g:master

LGTM, r+,

Thanks autra!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/86d6d0b7fb7a0e21d76a4162fd474722d72bd249

Comment 6

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK v2.6 and Flame KK v2.6 512mb by the STR in comment 0.

Actual results: Tap the search filed, the text within cancel button is center-aligned.

See attachment: Verified_Aries_KK_v2.6_search.png
Reproduce rate: 0/10

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151107001102
Gaia Revision          c3436122d678911d04b8f491724596116890ff9b
Gaia Date              2015-11-06 18:22:03
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151106.232924
Firmware Date          Fri Nov  6 23:29:32 UTC 2015
Bootloader             s1

Device: Flame KK 2.6 512mb (master)(Pass)
Build ID               20151108150206
Gaia Revision          c3436122d678911d04b8f491724596116890ff9b
Gaia Date              2015-11-06 18:22:03
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e2a910c048dc82fc3be53475f18e7f81f03e377b
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151108.183921
Firmware Date          Sun Nov  8 18:39:33 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 7

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_Aries_KK_v2.6_search.png

Comment 8

[Augustin Trancart [:autra]]

Comment on attachment 8684245 [details] [review]
[gaia] Phoxygen:bug1217781-cancel_button_text_position > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Slight visual impact, especially on large size screen and on languages where the word "cancel" is small.
[Testing completed]: on flame and z3c master
[Risk to taking this patch] (and alternatives if risky): Very low, only simple css change
[String changes made]: none

Comment 9

[Mahendra Potharaju [:mahe]]

Comment on attachment 8684245 [details] [review]
[gaia] Phoxygen:bug1217781-cancel_button_text_position > mozilla-b2g:master

Approved for 2.5

Thanks

Comment 10

[Carsten Book [:Tomcat]]

landed in 2.5 https://github.com/mozilla-b2g/gaia/commit/d1e8a717d154adb9d0a79e830fcd72b252b24d2e

Comment 11

[Lance（leave from Mozilla）]

Attachment: Verify: Verified_Aries_KK_v2.5.3GP

This bug has been verified as "pass" on the latest build of Aries KK v2.5 by the STR in comment 0.

Actual results: Tap the search filed, the text within cancel button is center-aligned.
See attachment: Verified_Aries_KK_v2.5.3GP
Reproduce rate: 0/10


Device: Aries KK 2.5 (Pass)
Build ID               20151116174534
Gaia Revision          9473dbcbebf4e758a3b73200968efc69071b4312
Gaia Date              2015-11-16 15:49:25
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17877d161e5f62726027ee70101a7004dcad5a69
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151116.165317
Firmware Date          Mon Nov 16 16:53:25 UTC 2015
Bootloader             s1

Comment 12

[Lance（leave from Mozilla）]

Attachment: Picture: Verified_Aries_KK_v2.5.png