1217791 - [Dialer]The phone number or contact name is too close to the line under it.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Alissa（leave from Mozilla）]

Attachment: Dialer_contact name&phone number.png

[1.Description]:
[Arieskk_v2.5][Flamekk_v2.5][Dialer]Open call log page and long tap one call log, we can see the contact name or phone number is too close to the line under it.
see attachment:Dialer_contact name&phone number.png

[2.Testing Steps]: 
1. Launch Dialer. 
2. Tap call log tab. 
3. Long tap one call log. 
4. Observe the action page. 

[3.Expected Result]: 
4.The phone number or the contact should vertically center aligned.

[4.Actual Result]: 
4.The phone number or contact name is too close to the line under it.

[5.Reproduction build]: 
Device: AriesKK_2.5 [Affected]
Build ID               20151023005002
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151023.001128
Firmware Date          Fri Oct 23 00:11:35 UTC 2015
Bootloader             s1

Device: FlameKK_v2.5[Affected]
Build ID               20151022150207
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/76bd0c01d72e64ca4f261ffdb2652a91f961e930
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151022.185000
Firmware Date          Thu Oct 22 18:50:13 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: FlameKK_v2.2[Unaffected] 
Build ID               20151022033039
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7bc753230036
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151022.070332
Firmware Date          Thu Oct 22 07:03:43 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Gabriele Svelto [:gsvelto]]

[Blocking Requested - why for this release]: I've identified the bug that regressed this, it's bug 1211954 and it landed on v2.5 too so nom'ing. The fix is fortunately just a one-line change.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1217791-call-group-info-header-fix > mozilla-b2g:master

Comment 3

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8688975 [details] [review]
[gaia] gabrielesvelto:bug-1217791-call-group-info-header-fix > mozilla-b2g:master

The issue was caused by the insertion of the <p> element. Since <p> elements have their own layout it got pushed down by the CSS code as if there was another line of text above it. Replacing the <p> element with a <span> which doesn't have a "native" layout fixed the issue. The name now appears in the correct place and the direction is still correctly selected automatically in RTL mode.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comms triage: Visual regression not major enough to hold the release on.

Do not hesitate to ask for approval once the patch is done.

Comment 5

[Tamara Hills [:thills]]

Comment on attachment 8688975 [details] [review]
[gaia] gabrielesvelto:bug-1217791-call-group-info-header-fix > mozilla-b2g:master

Hi Gabriele,

This looks good. I did test out.  Sorry for the lag.

-tamara

Comment 6

[Gabriele Svelto [:gsvelto]]

Thanks Tamara, merged to gaia/master c650319e61a7d6981a41e7591932c3bd12da4d59

https://github.com/mozilla-b2g/gaia/commit/c650319e61a7d6981a41e7591932c3bd12da4d59

Comment 7

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8688975 [details] [review]
[gaia] gabrielesvelto:bug-1217791-call-group-info-header-fix > mozilla-b2g:master

Asking for approval since this is very low risk and we regressed just before forking out v2.5

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): regressed by bug 1211954
[User impact] if declined: Visual glitch in the call information overlay, see attachment 8678041 [details]
[Testing completed]: Tested on a device and in the emulator
[Risk to taking this patch] (and alternatives if risky): Practically no risk, this just replaces a <p> element with a <span> one to ensure the layout is correct
[String changes made]: None

Comment 8

[Alissa（leave from Mozilla）]

This issue has been verified as pass on latest build of Flamekk master and Arieskk master.
Rate:0/10

Device: Flame master user[pass]
Build ID               20151206150208
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151206.182655
Firmware Date          Sun Dec  6 18:27:07 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master build(pass)
Build ID               20151207142341
Gaia Revision          24ed003a53a81f63367e265fa7117cbe7d23d4c8
Gaia Date              2015-12-07 03:36:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/59bc3c7a83de7ffb611203912a7da6ad84535a5a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151207.134432
Firmware Date          Mon Dec  7 13:44:39 UTC 2015
Bootloader             s1

Comment 9

[Mahendra Potharaju [:mahe]]

Comment on attachment 8688975 [details] [review]
[gaia] gabrielesvelto:bug-1217791-call-group-info-header-fix > mozilla-b2g:master

Limiting 2.5 only to TV patches. Foxfooders getting updates from master/b2g-ota branch. Removing the uplift nomination.

Thank you