1217802 - Optimize frame buffer size during scanning in MP3Demuxer

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Eugen Sawin [:esawin]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1163667#c31 for details.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1217802-1.1-Decrease-buffer-size-when-scanning-f.patch

Decrease scanning buffer size, carrying over r+ from https://bugzilla.mozilla.org/show_bug.cgi?id=1163667#c35.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: 0002-Bug-1217802-2.1-Return-0-for-incomplete-ID3-header-s.patch

When verifying my claim [1] that we can set the buffer size arbitrary small, I've noticed that we fail to recognize ID3 headers with large sizes properly when their size field spans across multiple buffer lengths.

The reason for this is because we report the incomplete ID3 tag size before finishing reading the ID3 header.

This patch fixes it, we only report the ID3 tag size, once we have fully parsed it.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1163667#c36

Comment 3

[Eugen Sawin [:esawin]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=960f55f8c6bc

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7f29a360692
https://hg.mozilla.org/integration/mozilla-inbound/rev/0423359e6667

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7f29a360692
https://hg.mozilla.org/mozilla-central/rev/0423359e6667