1217851 - eslint custom rule import-headjs-globals.js does not work on windows

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Patrick Brosset <:pbro>]

This rule lives in:
eslint-plugin-mozilla\lib\rules\import-headjs-globals.js

It's enabled in the devtools .eslintrc file.

Its job is to check if the file name is browser_*.js and if yes, locate the nearest head.js and import all globals from there so that eslint later doesn't complain about using undefined things when linting the test.

Turns out the way the rule is implemented doesn't work on Windows.

var isTest = /.*\/browser_.+\.js$/.test(pathAndFilename);

There's an assumption in the regex that path separators are forward slashes /
Just removing this character from the regex makes it work on Windows.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: MozReview Request: Bug 1217851 - Fix mozplugin's import-headjs-globals on Windows r?=pbro

Bug 1217851 - Fix mozplugin's import-headjs-globals on Windows r?=pbro

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We shouldn't remove the slash altogether as that would cause new errors. This patch simply changes this regex:
/.*\/browser_.+\.js$/

To this:
/.*[\\/]browser_.+\.js$/

Tests just fine on both osx and Win 10

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8678815 [details]
MozReview Request: Bug 1217851 - Fix mozplugin's import-headjs-globals on Windows r?=pbro

https://reviewboard.mozilla.org/r/23253/#review20725

Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/10533587f045

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/10533587f045