1217884 - There is double spacing between the start / end of a toolbar and a devtools input field

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: current-double-spacing.png

There's a 3px padding on the devtools-toolbar and another 3px spacing for the devtools-searchbox/devtools-textinput/devtools-searchinput thing.

We should collapse this to just 3px in this case so the spacing is consistent with other devtools toolbars.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1217884 - Remove double spacing between devtools toolbar and devtools inputs;r=pbrosset

Bug 1217884 - Remove double spacing between devtools toolbar and devtools inputs;r=pbrosset

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: with-patch-applied.png

Screenshot with patch applied

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8678196 [details]
MozReview Request: Bug 1217884 - Remove double spacing between devtools toolbar and devtools inputs;r=pbrosset

https://reviewboard.mozilla.org/r/23127/#review20705

Nice. I've tested this locally and the search/input boxes looked good to me.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/03eec3bcf293

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/03eec3bcf293