There is double spacing between the start / end of a toolbar and a devtools input field

RESOLVED FIXED in Firefox 44

Status

()

Firefox
Developer Tools: Framework
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

Trunk
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

(Whiteboard: [polish-backlog][devtools-ux][difficulty=easy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
Created attachment 8678193 [details]
current-double-spacing.png

There's a 3px padding on the devtools-toolbar and another 3px spacing for the devtools-searchbox/devtools-textinput/devtools-searchinput thing.

We should collapse this to just 3px in this case so the spacing is consistent with other devtools toolbars.
(Assignee)

Comment 1

2 years ago
Created attachment 8678196 [details]
MozReview Request: Bug 1217884 - Remove double spacing between devtools toolbar and devtools inputs;r=pbrosset

Bug 1217884 - Remove double spacing between devtools toolbar and devtools inputs;r=pbrosset
Attachment #8678196 - Flags: review?(pbrosset)
(Assignee)

Updated

2 years ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8678200 [details]
with-patch-applied.png

Screenshot with patch applied
(Assignee)

Updated

2 years ago
Attachment #8678193 - Attachment filename: Screenshot 2015-10-23 08.54.54.png → current-double-spacing.png
(Assignee)

Updated

2 years ago
Attachment #8678193 - Attachment description: Screenshot 2015-10-23 08.54.54.png → current-double-spacing.png
Comment on attachment 8678196 [details]
MozReview Request: Bug 1217884 - Remove double spacing between devtools toolbar and devtools inputs;r=pbrosset

https://reviewboard.mozilla.org/r/23127/#review20705

Nice. I've tested this locally and the search/input boxes looked good to me.
Attachment #8678196 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/03eec3bcf293
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.