1217890 - Ctrl+Click/Shift+Click on image attachments does not open them in new tabs, with bugzilla's experimental UI

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Enable Bugzilla's experimental UI enhancements.

 2. Visit bug 1103394 or some other bug with image attachments.

[ Motivation: let's say you want to open the various image attachments each in their own tab, for quick & easy comparison.]

 3. Ctrl+click an image link (e.g. "frame1", "frame2" in the attachments list on bug 1103394)

EXPECTED RESULTS: Image should open in a new tab.
ACTUAL RESULTS: Image opens in the current tab, in a modal popup.


The ACTUAL RESULTS make sense (or at least, I can get used to them) for a simple "click" on an image attachment. But I'd expect that Ctrl+Click should still be passed off to the browser, to open the link in a new tab. (& similarly shift+click should open it in a new window)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Does it have an onclick handler? If so, bug 547861 comes to mind.

Comment 2

[Daniel Holbert [:dholbert]]

The element doesn't have an explicit "onclick" attribute (unlike the testcase in that bug), but I'm assuming a click handler is set up via JS somehow.  So, this probably is indeed a variant of bug 547861, on the platform side.

But I think it's also possible for Bugzilla's UI to handle this (by e.g. checking the event [if using an event-handler that receives the event object as an arg] to see if any modifier keys like "Shift"/"Ctrl" were held down when the click was initiated).

Hence, keeping this bug separate from bug 547861, in the hopes that maybe we can tweak Bugzilla to fix this.

Comment 3

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   3628309..c36506a  master -> master