1217958 - (Gloda) Open Message in Conversation breaks for Local Folders, if multiple messages moved or Archived from imap to local. Error "Couldn't find a collection for msg".

Status: NEW

(MailNews Core :: Database, defect)

Description

[CC]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20151015172656

Steps to reproduce:

Thunderbird 38.3.0 on Linux (Kubuntu 15.04)

If I move a group of messages from one remote folder to another remote folder, even across accounts, the conversational threading is maintained: "Open Message in Conversation" works as it should.

If I move a single message at a time from a remote folder to a LocalFolder, the conversational threading is maintained, and "Open Message in Conversation" works as it should.

Then I try moving >1 message at a time from a remote folder to a LocalFolder...


Actual results:

...with >1 message moved at a time from a remote folder to a LocalFolder, the conversational threading breaks, and "Open Message in Conversation" does nothing. Sometimes "Open Message in Conversation" is not even available in the context menu, and sometimes it is, but in either case it doesn't work.

Selecting "undo" or manually moving the messages back to their original folder restores the conversational threading.

This all makes it highly undesirable / impossible to use LocalFolders for message archiving, which is my goal.

In case it matters, note that my LocalFolders is symlinked to a separate drive.

I see nothing coming up in the terminal stdout when doing these tests.



Expected results:

Conversational threading should be maintained. It clearly can be, since moving one at a time works fine.

Perhaps there is some kind of race condition happening when moving multiple messages?

Comment 1

[Wayne Mery (:wsmwk)]

> Perhaps there is some kind of race condition happening when moving multiple messages?

Race conditions are highly overrated :)

Does it happen if you have started Thunderbird in safe mode? https://support.mozilla.org/en-US/kb/safe-mode

Comment 2

[CC]

I'm ashamed that I didn't test in safe mode, but yes, same behavior, bug is still present.

If it ends up being a race condition I totally get a thunderbird point. :-)

Comment 3

[CC]

Poking through the code I get as far as this: http://mxr.mozilla.org/comm-release/source/mailnews/imap/src/nsImapMailFolder.cpp#8148

...but I have a feeling that's not where the real action is re: this bug. I wish I understood the overall architecture better, but I don't think I can figure this out myself.

If anyone can duplicate and confirm this bug, that'd be great. A decade of email languishes, unarchived and vulnerable. :-)

Comment 4

[CC]

Attachment: tbird_threadbug.gif

animated gif demonstrating the issue

Comment 5

[CC]

Hi -- I have now tested this with TB 45 in Windows 8.1 -- a fresh install, configured with access to a test account, and running in safe mode. The issue is the same as with Linux (now tested also on 38.5.1 in Linux). (I changed the platforms to "ALL" but have not actually tested on all platforms.)

I have created an animated gif that visually demonstrates the issue happening. It's 100% reproducible and reliably broken. In the gif you can see that moving the messages back to the remote folders restores the conversational threading. The same thing happens for the related messages in the sent folder, although that is not demonstrated in the gif.

E.g. if you move the Inbox messages one at a time to the localfolders, and you move the Sent messages as a group to the localfolders, the conversation view only shows those moved from the Inbox.

I also note that in the test done for the gif, localfolders was in the default location.

If anyone has a minute to check this out, I'd really appreciate it. This seems to me a pretty serious breakage of a fundamental feature, no? Assuming it's not related to my IMAP servers somehow, it seems like there must be lots of people affected by this?

Thanks for any time you can give to it!

Comment 6

[Wayne Mery (:wsmwk)]

Andre, 
Can you reproduce?

Comment 7

[Andre Klapper]

(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #6)
> Andre, Can you reproduce?

Wayne: I am not a Thunderbird user, sorry.

Comment 8

[Wayne Mery (:wsmwk)]

Chris, can you reproduce?

Comment 9

[CC]

Confirming that this is still broken in TB 45.2 on both Win 8.1 and Kubuntu 16.04.1. Animated GIF demonstrating the issue is attached. Thanks for any attention you can give to it!

Comment 10

[CC]

Perhaps a clue: I checked the error console while moving messages individually: no errors appeared.

When moving as a group, the error console outputs:

2016-08-21 14:03:51	gloda.index_msg	ERROR	Problem encountered during message move/copy: gloda_indexer_msgsMoveCopyCompleted@resource:///modules/gloda/index_msg.js:2385:32

When I try to open-in-conversation on a moved message the error console shows:

Timestamp: 2016-08-21 2:04:08 PM
Error: Couldn't find a collection for msg: [xpconnect wrapped nsIMsgDBHdr]
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 2843

The first error message seems to point to this line: https://dxr.mozilla.org/comm-esr45/source/mailnews/db/gloda/modules/index_msg.js#2385

Perhaps aDestMsgHdrs is not being populated when groups of messages are moved to local folders?

(In case I misinterpreted the DXR hierarchy, I also confirmed that the same line is at 2385 in the index_msg.js in my test installation's omni.ja)

Comment 11

[Chris Ramsden]

Confirmed on TB47.0/Windows 7 Pro.

Comment 12

[Chris Ramsden]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #8)
> Chris, can you reproduce?

Confirmed on TB47.0/Windows 7 Pro.

Comment 13

[CC]

Would it help to mark this bug as confirmed, since Chris R. has confirmed it? Thanks for looking at it!

Comment 14

[Wayne Mery (:wsmwk)]

Confirming (But I haven't tested this myself)

Does it also happen with beta http://www.mozilla.org/en-US/thunderbird/channel/ ?

Comment 15

[CC]

Just tested with 52b04 32bit on Win 8.1 -- same behavior all around, yes. Thanks!

Comment 16

[CC]

Hi - Just curious if anyone knows if this sort of bug is on the table for attention these days, or if I should seek other ways of archving/backing up my email? Thanks!

Comment 17

[CC]

This bug is still present in 60.2.1. Seems serious? Anyone have a sec to check it out? Thanks!

Comment 18

[Dorphus]

Still present in 60.8.0 and this bug is much wider than just Local Folders. If you move your entire Inbox/Sent folders to Archive, "open message in conversation" stops working inside archive completely. Very painful if the archive contains k's of emails.

Error message in the console:

Couldn't find a collection for msg: [xpconnect wrapped nsIMsgDBHdr] msgHdrViewOverlay.js:2894

Comment 19

[Wayne Mery (:wsmwk)]

Very well described by CC, and thanks Dorphus for confirming. I can also confirm.

This goes back to bug 641446, and others listed in query [1] like Bug 989884 - Gloda index error "Problem encountered during message move/copy: undefined" when move more than one messages to local folder. If "outdated msf condition" exists Gloda should take some action or wait for recovery (rebuild/repair-index)

[1] https://bugzilla.mozilla.org/buglist.cgi?f1=short_desc&o3=anywordssubstr&bug_type=defect&list_id=14814894&o1=allwordssubstr&resolution=---&classification=Client%20Software&classification=Developer%20Infrastructure&classification=Components&classification=Server%20Software&classification=Other&f4=component&query_format=advanced&f3=short_desc&o4=nowordssubstr&f2=OP&longdesc=Couldn%27t%20find%20a%20collection%20for%20msg&f5=CP&product=MailNews%20Core&product=Thunderbird&longdesc_type=substring