Use react-dev as our only react lib

RESOLVED FIXED in Firefox 44

Status

()

Firefox
Developer Tools
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jsantell, Assigned: jsantell)

Tracking

43 Branch
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

Running into a lot of issues with react-dev not being built unless DEBUG_JS_MODULES is set, so while there is a slight perf overhead of dev, we won't need to have 2 copies in tree, and can still use the plugins like React.addons.TestUtils.

This isn't the best solution, but it'll work for now and give us more test coverage until we think of a way to do this, as this is the first time we're dealing with conditional envs in our builds with third party
(Assignee)

Updated

3 years ago
Blocks: 960776
Created attachment 8678311 [details] [diff] [review]
1217979-react-dev.patch
Attachment #8678311 - Flags: review?(jlong)
Comment on attachment 8678311 [details] [diff] [review]
1217979-react-dev.patch

Review of attachment 8678311 [details] [diff] [review]:
-----------------------------------------------------------------

+1, sucks that there are so many problems with it but we can figure it out later.
Attachment #8678311 - Flags: review?(jlong) → review+
https://hg.mozilla.org/mozilla-central/rev/ef5382853305
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.