Closed
Bug 1218010
Opened 9 years ago
Closed 9 years ago
Shorten the poll interval waiting for httpd.js startup
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
Details
Attachments
(1 file)
We wait for the presence of "server_alive.txt" before starting the test. We poll every second for it -- I noticed in the automation logs we always wait about a second. If I drop the polling interval down to 100ms locally it starts up on the second iteration.
A small thing of course, but it's perceptible locally (and will have an effect for every dir).
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1218010 - Shorten the polling interval when waiting for httpd.js startup in mochitest. r=ahal
I noticed in automation logs that we always wait about 1s for httpd.js to be
ready -- this is the minimum we could wait if we wait at all, because we poll
every second. Bringing the polling interval down to 100ms locally shows we
succeed after waiting just once. This is a perceptible speedup, and will
have an effect for every dir now that we run-by-dir.
Attachment #8678360 -
Flags: review?(ahalberstadt)
Comment 2•9 years ago
|
||
Comment on attachment 8678360 [details]
MozReview Request: Bug 1218010 - Shorten the polling interval when waiting for httpd.js startup in mochitest. r=ahal
https://reviewboard.mozilla.org/r/23189/#review20669
Good catch! Any reason not to bump it down even further to .05 or even .01?
Attachment #8678360 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Comment on attachment 8678360 [details]
> MozReview Request: Bug 1218010 - Shorten the polling interval when waiting
> for httpd.js startup in mochitest. r=ahal
>
> https://reviewboard.mozilla.org/r/23189/#review20669
>
> Good catch! Any reason not to bump it down even further to .05 or even .01?
Don't think so. Let's go with .05.
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•