1218027 - --with-system-icu fails: js/src/jsapi.cpp:69: error: visibility does not match previous declaration

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[Jan Beich]

Attachment: Unbreak --with-system-icu build after bug 1172609

Nothing seems to use system ICU by default except for some downstream. So, the build regressed once a file not in config/system-headers was included.

In file included from obj/js/src/Unified_cpp_js_src8.cpp:11:
In file included from js/src/jsapi.cpp:69:
In file included from /usr/local/include/unicode/timezone.h:40:
In file included from /usr/local/include/unicode/unistr.h:31:
In file included from /usr/local/include/unicode/std_string.h:33:
In file included from dist/system_wrappers/string:3:
In file included from /usr/include/c++/v1/string:439:
In file included from dist/system_wrappers/algorithm:3:
In file included from /usr/include/c++/v1/algorithm:628:
In file included from dist/system_wrappers/memory:3:
In file included from /usr/include/c++/v1/memory:600:
In file included from dist/system_wrappers/typeinfo:3:
/usr/include/c++/v1/typeinfo:72:7: error: visibility does not match previous declaration
class _LIBCPP_EXCEPTION_ABI type_info
      ^
/usr/include/c++/v1/__config:221:47: note: expanded from macro '_LIBCPP_EXCEPTION_ABI'
#define _LIBCPP_EXCEPTION_ABI __attribute__ ((__visibility__("default")))
                                              ^
config/gcc_hidden.h:6:13: note: previous attribute is here
#pragma GCC visibility push(hidden)
            ^

Comment 1

[Jan Beich]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ce1141a5be5

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fa665625111

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3fa665625111

Comment 4

[Jan Beich]

Comment on attachment 8678378 [details] [diff] [review]
Unbreak --with-system-icu build after bug 1172609

Approval Request Comment
[Feature/regressing bug #]: bug 1172609 regression
[User impact if declined]: broken build --with-system-icu
[Describe test coverage new/current, TreeHerder]: NPOTB after bug 1172609, comment 1, m-i, m-c
[Risks and why]: Low. Mismerge outside of #ifdef MOZ_SHARED_ICU may break build or leak internal symbols.
[String/UUID change made/needed]: None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8678378 [details] [diff] [review]
Unbreak --with-system-icu build after bug 1172609

Not part of the build, I think it's ok to uplift this to aurora and beta (now that we don't freeze aurora build configs anymore)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7f25e05e5809

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/70cd8ea76dbe

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7f25e05e5809