1218039 - Make it easier to tell what kind of principal you have

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[Bobby Holley (:bholley)]

Right now there are various roundabout ways to do this, but we should just expose something obvious on nsIPrincipal. I've got a patch.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Add a nice interface for both C++ and JS to access the principal kind. v1

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8678406 [details] [diff] [review]
Add a nice interface for both C++ and JS to access the principal kind. v1

Review of attachment 8678406 [details] [diff] [review]:
-----------------------------------------------------------------

This is an awesome idea, thanks! Can we also expose |kind| on the IDL level? It would be so cool sometime to just print the principals type (eh, kind). I know it's annoying to expose enums with IDL, but would be useful imo, what do you think?

Comment 3

[Bobby Holley (:bholley)]

(In reply to Gabor Krizsanits [:krizsa :gabor] from comment #2)
> This is an awesome idea, thanks! Can we also expose |kind| on the IDL level?
> It would be so cool sometime to just print the principals type (eh, kind). I
> know it's annoying to expose enums with IDL, but would be useful imo, what
> do you think?

Do you mean to access from C++ or JS? With C++ you can already get it via BasePrincipal::Cast. For debugging JS, I think it's good enough to print .origin, which has all the information needed.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b90b038ae4c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b90b038ae4c

Comment 6

[Gabor Krizsanits (INACTIVE)]

> Do you mean to access from C++ or JS? With C++ you can already get it via
> BasePrincipal::Cast. For debugging JS, I think it's good enough to print
> .origin, which has all the information needed.

Oh, you're right I forgot that we already have meaningful origin for all principals.