1218104 - Failure in test_marketplace_addon.py because of changing install button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

I get this failure with this test:
TEST-UNEXPECTED-ERROR | test_marketplace_addon.py TestSearchMarketplaceAndInstallAddon.test_search_and_install_app | TimeoutException: TimeoutException: Timed out after 22.4 seconds


Traceback (most recent call last):
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/marketplace/test_marketplace_addon.py", line 62, in test_search_and_install_app
    results = marketplace.install_addon(self.addon_name_to_install)
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/apps/marketplace/app.py", line 124, in install_addon
    addon_page.install_link()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/apps/marketplace/app.py", line 132, in install_link
    expected.element_present(*self._addon_install_locator))
  File "/Users/mwargers/.virtualenvs/zapion_test2/lib/python2.7/site-packages/marionette_driver-1.0.0-py2.7.egg/marionette_driver/wait.py", line 143, in until
    cause=last_exc)
TEST-INFO took 110779ms

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1218104 > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8678474 [details] [review]
[gaia] mwargers:1218104 > mozilla-b2g:master

This makes us at least go past this stage, but then I get a timeout failure in system.wait_for_system_banner_displayed().
That happens because the add-on isn't getting installed at all, which seems like a real issue.

Comment 3

[No-Jun Park [:njpark]]

hmm, in my case, I get the same failure, but the button says 'M' in Status Bar is installed, Yet 'M' isn't showing up nor I get the toaster.  I agree it's a bug.  As far as the fix goes, it looks good.

Comment 4

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #2)
> That happens because the add-on isn't getting installed at all, which seems
> like a real issue.

I filed bug 1218105 for this.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1218108 > mozilla-b2g:master

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8678474 [details] [review]
[gaia] mwargers:1218104 > mozilla-b2g:master

The change looks good to me.

Comment 7

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/a04dc21b1d99c971e1e1e550afd0a3b45b489342