XPInstallObserver.observe() generates JavaScript Error: "NS_NOINTERFACE: " @ browser.js - line: 5858

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: capella, Assigned: vivek)

Tracking

unspecified
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Currently points to:
   http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js?rev=214bc95f9d20&mark=5858-5858#5842

Quick log shows related to:
   aSubject: [object ChromeWindow]
   aTopic: [browser-delayed-startup-finished]

Comment 1

3 years ago
Vivek, can you take a look at this?
Blocks: 1201547
Flags: needinfo?(vivekb.balakrishnan)
(Assignee)

Comment 2

3 years ago
Created attachment 8678962 [details]
MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

Bug 1218129: Added instanceof check before call to QueryInterface r?margaret
Attachment #8678962 - Flags: review?(margaret.leibovic)
https://reviewboard.mozilla.org/r/23287/#review20751

::: mobile/android/chrome/content/browser.js:5863
(Diff revision 1)
> -    if (aSubject) {
> +    if (aSubject && aSubject instanceof Ci.amIWebInstallInfo) {

I might be wrong, but I think instanceof _does_ a QueryInterface as well, so you might only need:

installInfo = aSubject;

Not a big deal either way.
(Assignee)

Comment 4

3 years ago
Comment on attachment 8678962 [details]
MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

Thanks for that trick @mfinkle

Comment 5

3 years ago
Comment on attachment 8678962 [details]
MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

https://reviewboard.mozilla.org/r/23287/#review20761
Attachment #8678962 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/81d08a1039202a9966009ea282dea10a69bf68d2
Bug 1218129: Added instanceof check before call to QueryInterface r=margaret
(Assignee)

Updated

3 years ago
Flags: needinfo?(vivekb.balakrishnan)
https://hg.mozilla.org/mozilla-central/rev/81d08a103920
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44

Updated

3 years ago
Assignee: nobody → vivekb.balakrishnan
You need to log in before you can comment on or make changes to this bug.