1218129 - XPInstallObserver.observe() generates JavaScript Error: "NS_NOINTERFACE: " @ browser.js - line: 5858

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

Currently points to:
   http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js?rev=214bc95f9d20&mark=5858-5858#5842

Quick log shows related to:
   aSubject: [object ChromeWindow]
   aTopic: [browser-delayed-startup-finished]

Comment 1

[:Margaret Leibovic]

Vivek, can you take a look at this?

Comment 2

[Vivek Balakrishnan[:vivek]]

Attachment: MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/23287/#review20751

::: mobile/android/chrome/content/browser.js:5863
(Diff revision 1)
> -    if (aSubject) {
> +    if (aSubject && aSubject instanceof Ci.amIWebInstallInfo) {

I might be wrong, but I think instanceof _does_ a QueryInterface as well, so you might only need:

installInfo = aSubject;

Not a big deal either way.

Comment 4

[Vivek Balakrishnan[:vivek]]

Comment on attachment 8678962 [details]
MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

Thanks for that trick @mfinkle

Comment 5

[:Margaret Leibovic]

Comment on attachment 8678962 [details]
MozReview Request: Bug 1218129: Added instanceof check before call to QueryInterface r?margaret

https://reviewboard.mozilla.org/r/23287/#review20761

Comment 6

[Vivek Balakrishnan[:vivek]]

https://hg.mozilla.org/integration/fx-team/rev/81d08a1039202a9966009ea282dea10a69bf68d2
Bug 1218129: Added instanceof check before call to QueryInterface r=margaret

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81d08a103920