Closed Bug 1218150 Opened 6 years ago Closed 6 years ago

Mark the members of Clients as NewObject

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: ehsan.akhgari, Unassigned)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
Attachment #8678534 - Flags: review?(bzbarsky)
Adding dev-doc-needed to double check that the text of the documentation is clear these always create a new object.
Keywords: dev-doc-needed
Comment on attachment 8678534 [details] [diff] [review]
Mark the members of Clients as NewObject

You don't need the [Throws] bits anymore: promise-returning [NewObject] methods are assumed to throw by codegen, since promise creation can throw.

r=me with those bits removed.
Attachment #8678534 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/d67a59a19966
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Switching to ddc, I checked that the comment are clear enough in the docs about new objects or same objects returned.
You need to log in before you can comment on or make changes to this bug.