Closed
Bug 1218150
Opened 10 years ago
Closed 10 years ago
Mark the members of Clients as NewObject
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
2.66 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8678534 -
Flags: review?(bzbarsky)
|
||
Comment 2•10 years ago
|
||
Adding dev-doc-needed to double check that the text of the documentation is clear these always create a new object.
Keywords: dev-doc-needed
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8678534 [details] [diff] [review]
Mark the members of Clients as NewObject
You don't need the [Throws] bits anymore: promise-returning [NewObject] methods are assumed to throw by codegen, since promise creation can throw.
r=me with those bits removed.
Attachment #8678534 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
|
||
Comment 6•10 years ago
|
||
Switching to ddc, I checked that the comment are clear enough in the docs about new objects or same objects returned.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•