Closed Bug 1218212 Opened 4 years ago Closed 4 years ago

Do not override gaia-radio styles in FTU metrics collection radio

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S10 (30Oct)
Tracking Status
b2g-master --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

FTU is currently overriding the default styles of web components, and unless there is a very good reason to do so, we should not do this.

According to the spec here, it seems we should be able to remove these styles: https://mozilla.app.box.com/s/yv76rhogfpp2qp75cdpx35jb0673bd1h
Comment on attachment 8678605 [details] [review]
[gaia] KevinGrandon:bug_1218212_fte_metrics_styles > mozilla-b2g:master

Sam - could you review this? Also let me know if you want to get a visual pass from a UX designer, I'm not sure if we did one for the original implementation. Thanks!
Attachment #8678605 - Flags: review?(sfoster)
Comment on attachment 8678605 [details] [review]
[gaia] KevinGrandon:bug_1218212_fte_metrics_styles > mozilla-b2g:master

Thanks for this. Looks like a clear improvement to me - especially the improved text color contrast.
Attachment #8678605 - Flags: review?(sfoster) → review+
Merged to master: https://github.com/mozilla-b2g/gaia/commit/1d12c74e2f8b2eb8d2ce9df4bae4ac4f075b779b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in before you can comment on or make changes to this bug.