Closed Bug 1218216 Opened 7 years ago Closed 7 years ago

Make invitation overlay more context aware

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Lightning 4.6
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

References

Details

Attachments

(1 file, 1 obsolete file)

The invitation overlay is currently not context aware, to e.g. handle sent invitations differently from received ones. In coincidence with the new modification decoration this lead to mixing up previous and current reversion of an invitation.

Also, if one has removed an event from the calendar, related sent invitation may display accept/decline buttons to the former organizer.
This patch

- makes modification decoration application context/sequence aware
- add modified imipbar handling for sent invitations rsp. for messages in sent folders, to be precise.
Attachment #8678607 - Flags: review?(philipp)
Insufficient check fixed at the begin of displayModifications to make sure there is something to compare.
Attachment #8678607 - Attachment is obsolete: true
Attachment #8678607 - Flags: review?(philipp)
Attachment #8684667 - Flags: review?(philipp)
Blocks: ltn47
Comment on attachment 8684667 [details] [diff] [review]
DisplayDifferencesVersionDependent-V2.diff

Review of attachment 8684667 [details] [diff] [review]:
-----------------------------------------------------------------

s/sent out/sent/ and then you are good. Any chance we can add tests for this?
Attachment #8684667 - Flags: review?(philipp) → review+
String updated.

https://hg.mozilla.org/comm-central/rev/2aa2ae33bf0a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.7
Depends on: 1326271
You need to log in before you can comment on or make changes to this bug.