1218232 - Reader View should style <code> blocks differently from the rest of text so they stand out more/less

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, enhancement, P3)

Description

[Franklin?]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20151014143721

Steps to reproduce:

Example page:
https://ponyfoo.com/articles/es6-promises-in-depth
(archived: https://web.archive.org/web/20150928184517/http://ponyfoo.com/articles/es6-promises-in-depth)

Start Reader View, and scroll down to one of the code examples. For example, there's a <pre> block after, "Often, a single parameter is used."


Actual results:

The code lines are properly in monospace, but there's no visual separator from the rest of the text.


Expected results:

There should be some sort of box around the code block.

----

The original text has a yellowish background for blocks of code. The Readability extension, which uses #F8F8F8 as its normal background color for daytime reading (night: #212324), has #FFF as the background color for <pre> (night: #2B2E2F).

Comment 1

[Jintao Hu]

Attachment: Bug 1218232 - Style code block differently from the rest of text. r=niklas,mtigley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e44d0e91e9ea
Style code block differently from the rest of text. r=mtigley

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e44d0e91e9ea

Comment 4

[Ardelean Oana, Desktop QA [:oardelean]]

This enhancement is implemented on Firefox 100.0b5(20220412185818) and Nightly 101.0a1(20220414092955). Tested on Win10, Ubuntu 20.04 and macOS 11.