panel specific styles should be defined in app.css or separated css

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: gasolin@mozilla.com)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently there are some panel specific styles defined in settings.css. 

We could move those panel specific styles into app.css so we can benefit from the lazyload of app.css.
(Assignee)

Updated

3 years ago
tracking-b2g: --- → backlog
(Assignee)

Updated

3 years ago
Assignee: nobody → gasolin
Created attachment 8679341 [details] [review]
[gaia] gasolin:issue-1218271 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8679341 [details] [review]
[gaia] gasolin:issue-1218271 > mozilla-b2g:master

The patch may save some loadtime by lazy load 670 lines of styles.


1. moves inner panel styles into app.css (not change the original structure so we can make sure nothing is missing during migration)
2. fix wallpaper styles in settings_large.css (wallpaper has been moved to homescreens panel)

Will file a followup to re-organize styles in app.css
Attachment #8679341 - Flags: review?(yzenevich)
(Assignee)

Comment 3

3 years ago
note: #mediaStorage and .wallpaper are customized in settings_large.css, lazy load them in app.css may broke the tablet style (well I suppose it was somewhat broken now...). Therefore I left it in settings.css in this initial patch.
Comment on attachment 8679341 [details] [review]
[gaia] gasolin:issue-1218271 > mozilla-b2g:master

Looks good see comment in PR. THanks!
Attachment #8679341 - Flags: review?(yzenevich) → review+
(Assignee)

Updated

3 years ago
Blocks: 1181023
(Assignee)

Updated

3 years ago
See Also: → bug 1219159
(Assignee)

Comment 5

3 years ago
file bug 1219159 to fix developer HUD related issue

merged https://github.com/mozilla-b2g/gaia/commit/1419469702856533a82a3ce3069aad3403e09b00

thanks!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.