1218282 - Add-ons: copy content_scripts field from manifest.json to update.webapp (mini-manifest)

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

In order to make bug 1216446 work (displaying warning on installation for add-ons that inject into the system app), the system needs to know the value of the content_scripts field in the add-ons manifest.json. Right now the only way to do that is to download the package, unzip it, and examine it's contents. But this defeats the purpose of the installation confirm dialog. So to make this bug work, we would need the Marketplace team to copy the content_scripts field from manifest.json to the update.webapp.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Maris, can you help me figure out if this is doable from Marketplace side for the 2.5 timeframe?

Note, that we can put the code into the system app to read the content_scripts field of the update.manifest, and then at any time (even beyond Nov. 2) Marketplace can add that field to the add-on manifests. But it would be nice to have something to test against before launch.

Comment 2

[Mathieu Pillard [:mat]]

I can add it easily right now if it's just copying it out as we store a copy of the original manifest in db and generate the update manifest on the fly.

Comment 3

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/3410

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks Mat!

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/d360650b84b926b7e50ae22bac93fdda992583f2

It will land on -dev in a few minutes, later on stage/prod.