Closed Bug 1218291 Opened 4 years ago Closed 4 years ago

app manifest version is not returned when installed from marketplace or WebIDE

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set

Tracking

(blocking-b2g:2.5?, firefox44 fixed)

RESOLVED FIXED
mozilla44
blocking-b2g 2.5?
Tracking Status
firefox44 --- fixed

People

(Reporter: gasolin, Assigned: fabrice)

References

Details

Attachments

(1 file)

==== clone from bug 1216075 comment 7 ====

I've checked the 

1. build-in addon
2. addon installed from marketplace
3. addon installed from web IDE

The later two does not shown manifest.version correctly though they have defined version in their manifest.json and update.webapp.

These issue might be related to the change of web extensions api,
[Blocking Requested - why for this release]: Can't correctly show the addon versions

Fabrice could you help check from the gecko side?
Blocks: 1216075
blocking-b2g: --- → 2.5?
Flags: needinfo?(fabrice)
What I mean for build-in addon are test add-ons

https://github.com/mozilla-b2g/gaia/tree/master/apps/settings/test/fixtures
We can add the version number to the synthetised manifest at https://mxr.mozilla.org/mozilla-central/source/dom/apps/UserCustomizations.jsm#121
Flags: needinfo?(fabrice)
For extensions, this copies the version from the extension manifest to the app manifest, and also keep it around in the registry as "extensionVersion". I need the later to help implement version checks when blocklisting.
Assignee: nobody → fabrice
Attachment #8679074 - Flags: review?(ferjmoreno)
Attachment #8679074 - Flags: review?(ferjmoreno) → review+
https://hg.mozilla.org/mozilla-central/rev/440638fde3aa
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.