1218291 - app manifest version is not returned when installed from marketplace or WebIDE

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[[e-mail]]

==== clone from bug 1216075 comment 7 ====

I've checked the 

1. build-in addon
2. addon installed from marketplace
3. addon installed from web IDE

The later two does not shown manifest.version correctly though they have defined version in their manifest.json and update.webapp.

These issue might be related to the change of web extensions api,

Comment 1

[[e-mail]]

[Blocking Requested - why for this release]: Can't correctly show the addon versions

Fabrice could you help check from the gecko side?

Comment 2

[[e-mail]]

What I mean for build-in addon are test add-ons

https://github.com/mozilla-b2g/gaia/tree/master/apps/settings/test/fixtures

Comment 3

[[:fabrice] Fabrice Desré]

We can add the version number to the synthetised manifest at https://mxr.mozilla.org/mozilla-central/source/dom/apps/UserCustomizations.jsm#121

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: addon-version.patch

For extensions, this copies the version from the extension manifest to the app manifest, and also keep it around in the registry as "extensionVersion". I need the later to help implement version checks when blocklisting.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/440638fde3aa

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/440638fde3aa