Closed
Bug 1218293
Opened 10 years ago
Closed 10 years ago
Get rid of fxsyncId field in bookmarks_store
Categories
(Firefox OS Graveyard :: Sync, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S10 (30Oct)
People
(Reporter: mbdejong, Assigned: mbdejong)
References
Details
Attachments
(1 file)
Since fxsyncId is now inside each fxsyncRecords entry, we can get rid of https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/adapters/bookmarks.js#L97-L98 and https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/adapters/bookmarks.js#L324 now.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mbdejong
Blocks: fxos-sync
Priority: -- → P2
Target Milestone: --- → FxOS-S10 (30Oct)
|
|
||
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8681234 -
Flags: feedback?(selee)
Attachment #8681234 -
Flags: feedback?(ferjmoreno)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8681234 [details] [review]
[gaia] michielbdejong:1218293-remove-fxsyncId > mozilla-b2g:master
Commit for this bug itself:
https://github.com/michielbdejong/gaia/commit/dfcd5b32eceef94e06864e901d7055aee2b03259
|
|
Assignee | |
Comment 3•10 years ago
|
||
This is my last P2 bug for the TV. I rebased it on bug 1214188 so they can be merged in that order without conflict. Once 1214188 is merged, I'll rebase and request review.
|
||
Updated•10 years ago
|
Attachment #8681234 -
Flags: feedback?(ferjmoreno) → feedback+
|
|
||
Updated•10 years ago
|
Attachment #8681234 -
Flags: feedback?(selee) → feedback+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8681234 -
Flags: review?(ferjmoreno)
|
|
||
Updated•10 years ago
|
Attachment #8681234 -
Flags: review?(ferjmoreno) → review+
|
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•