1218330 - [Add-On Manager] Affected App Name does not appear if the filter contains a wildcard (*)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[André Fiedler]

I think I found a small issue in the add-on detail panel. If I make a add-on with a filter for the settings app like this:

> {
>   "matches": [ "app://settings.gaiamobile.org/index.html" ],
>   "js": [ "settings.js" ]
> }

It will show the name "Settings" under the "Affected Apps" section in the add-on details panel (as expected). But the "settings.js" add-on will not get applied to the settings app, because the settings app will get called with an empty hash "#" from the home screen. So to fix this, I have to change the filter to:

> {
>   "matches": [ "app://settings.gaiamobile.org/index.html*" ],
>   "js": [ "settings.js" ]
> }

But now the "Affected Apps" section in the add-on details panel does not show "Settings" any more. So to fix both of this, I have to define the filter like this:

> {
>   "matches": [ 
>     "app://settings.gaiamobile.org/index.html",
>     "app://settings.gaiamobile.org/index.html*"
>   ],
>   "js": [ "settings.js" ]
> }

Now the name does appear and the "settings.js" get's applied. ;)

Comment 1

[[e-mail]]

Yura could you help take a look about this?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] yzen:bug-1218330 > mozilla-b2g:master

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8681301 [details] [review]
[gaia] yzen:bug-1218330 > mozilla-b2g:master

So we are implementing match patterns described here: 

https://developer.chrome.com/extensions/match_patterns

With a small addition of app: scheme.

You can see examples of valid and invalid pattern tested here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/sharedtest/test/unit/addons/match_pattern_test.js

Adding more tests that hopefully replicate your issue.

Comment 4

[[e-mail]]

Comment on attachment 8681301 [details] [review]
[gaia] yzen:bug-1218330 > mozilla-b2g:master

looks fine for test only change, thanks.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Added tests that verify the match pattern module supporting the above urls.
https://github.com/mozilla-b2g/gaia/commit/c330938eadff1a2c24bf6eba8844b41ad58f31cb