Status

()

P3
normal
3 years ago
9 months ago

People

(Reporter: emk, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [psm-backlog])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We had to dispatch to the main thread because of nsISSLErrorListener. Since bug 844351 removed nsISSLErrorListener, I believe we could call nsHandleSSLError directly.
(Reporter)

Comment 1

3 years ago
Created attachment 8678802 [details] [diff] [review]
patch
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8678802 - Flags: review?(dkeeler)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8678802 [details] [diff] [review]
patch

Oops, GetErrorLogMessage was main-thread only.
Attachment #8678802 - Flags: review?(dkeeler)
Maybe it would be best to push the error logging (the reason for GetErrorLogMessage) more towards the front-end. Maybe (shudder) nsSecureBrowserUIImpl? Or some other thing that keeps track of loads and would be notified when something failed for a security reason. This will help move away from doing all of this error string formatting in PSM, which is not really where we want it.
Whiteboard: [psm-assigned]
P1 because this is assigned. If that changes, this is probably a P3.
Priority: -- → P1
Assignee: VYV03354 → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Whiteboard: [psm-assigned] → [psm-backlog]
You need to log in before you can comment on or make changes to this bug.