The object-count-based leak check should have a single summary line with the leaked classes, similar to how the byte count just does a FAIL on a single line. Otherwise it will spam up the Treeherder suggestion box, and not provide a very useful summary for the Bugzilla intermittent bug, as seen in bug 1218290.
Created attachment 8680128 [details] [diff] [review] Give a summary for object-count leak checking. - Warn instead of fail for each unexpectedly leaking object. Large leaks can have a ton of different objects, which spams up the TreeHerder summary. - If there is a set of expected leaks, only include the unexpected ones in leakedObjectNames. This will make the summary more useful. - If we leaked unexpected objects, but did not exceed the threshold, then the summary message should be a failure. The number of leaked bytes will be off by a few kb, but it doesn't seem worth the extra complexity to compute the precise number of bytes of unexpectedly leaking objects. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1deadbd614af
Attachment #8680128 - Flags: review?(jgriffin)
Attachment #8680128 - Flags: review?(jgriffin) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
status-b2g-v2.5: --- → fixed
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
You need to log in before you can comment on or make changes to this bug.