[Messages][Tests] Add the "delete selected messages" integration test to "Conversation Edit Mode" suite

RESOLVED WONTFIX

Status

Firefox OS
Gaia::SMS
RESOLVED WONTFIX
2 years ago
11 months ago

People

(Reporter: martianwars, Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js][good first bug])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
We need to add an additional integration test to the Gaia::SMS marionette tests in the "Edit Mode" suite [1].
We have already added tests for most of the scenarios. We have to add the test for one last scenario where we test whether the user can delete selected messages.

The workflow is as follows :-
1. Enter edit mode. [2]
2. Select some messages. [3]
3. Press the delete button.
4. Assert the changes observed with the expected changes.


[1] - https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/test/marionette/conversation_test.js#L318
[2] - https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/test/marionette/conversation_test.js#L334
[3] - https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/test/marionette/conversation_test.js#L390-L396
(Reporter)

Updated

2 years ago
Whiteboard: [lang=js]
(Reporter)

Updated

2 years ago
Whiteboard: [lang=js] → [lang=js][good first bug]
Narrowed down bug title to conversation view and added references to the relevant bugs.
Blocks: 930556
See Also: → bug 1209419
Summary: Add the "delete selected messages" integration test to "Edit Mode" suite in Gaia::SMS → [Messages][Tests] Add the "delete selected messages" integration test to "Conversation Edit Mode" suite

Comment 2

2 years ago
Hi
I would like to take this as my first bug. Could you point me how should I get started?
Thank You
(Reporter)

Comment 3

2 years ago
Hi Arka,
It's great that you wish to work on this bug. Since it's your first bug, I recommend you to clone the forked version of the Gaia repository here [1]. [2] gives you detailed instructions.

You should follow the steps here to setup a proper pull request. [3]

Try making some of the changes made above and setup a successful PR on Github. I'll help you with the code thereafter. Also be sure to ask me for "review" on this Bugzilla page. You can see details under "Manual Submission" here [4]

Hoping to have fun working with you!

[1] - https://github.com/mozilla-b2g/gaia
[2] - https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Running_the_Gaia_codebase
[3] - https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Making_Gaia_code_changes
[4] - https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Submitting_a_Gaia_patch


@azasypkin - Anything else Arka needs to know?
Flags: needinfo?(azasypkin)
Yeah, I think it's enough for the start + maybe some info about integration tests itself [1].

Thanks Arka and Kalpesh!

[1] https://developer.mozilla.org/en-US/Firefox_OS/Automated_testing/Gaia_integration_tests
Flags: needinfo?(azasypkin)
Created attachment 8692456 [details] [review]
[gaia] TheShadow29:my-code-fix > mozilla-b2g:master

Comment 7

2 years ago
Plz ignore the previous pull request, I didn't give the proper title. I set up a new pull request [1].

[1]: https://github.com/mozilla-b2g/gaia/pull/33384
(Reporter)

Comment 8

2 years ago
Hi Arka,
It's great to see that you have started working on this.
I will review the code on Github.
Next time onward, you can press the "Details" section on the top of the conversation against the attachment and give me a feedback / review request. :) In the case the attachment doesn't exist, you can follow the instructions given in step #5 here [1]. Don't worry, Autolander usually does this for us :)

[1] - https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Submitting_a_Gaia_patch#Manual_patch_submission

Comment 9

2 years ago
Created attachment 8692491 [details] [review]
Adding integration tests

Done part1,2.
Attachment #8692491 - Flags: review?(kalpeshk2011)
(Reporter)

Comment 10

2 years ago
Comment on attachment 8692491 [details] [review]
Adding integration tests

Hi Arka, good try but you made a few syntax errors. I've commented on Github.
Attachment #8692491 - Flags: review?(kalpeshk2011)
Attachment #8692491 - Flags: review-
Attachment #8692491 - Flags: feedback-
(Reporter)

Comment 11

2 years ago
Hey Arka,
Haven't heard from you for some time. Are you having some issues? Come on #fxos on the IRC if this is the case. you can ask azasypkin, julienw, kumarrishav or me for help :) Also look at this https://github.com/azasypkin/gaia/blob/master/apps/sms/README.md
Flags: needinfo?(ark.sadhu2904)

Comment 12

2 years ago
Hi Kalpesh
Yes, I am having a few issues, with node and npm and was unable to fix it. I will come on IRC then, to discuss my doubts.
Flags: needinfo?(ark.sadhu2904)
BTW you need to have v4.0 for node, npm : 2.0+ (if you are on older version , better to update it)
(Reporter)

Comment 14

2 years ago
Arka,
would you be resuming work sometime soon? If not, I'll un-assign you for now if you are busy. You may resume this bug (if it isn't resolved by then) or work on something else :)
Flags: needinfo?(ark.sadhu2904)

Comment 15

2 years ago
Kalpesh, 
Sorry for my inactivity. Please do so, will resume the bug(if not resolved) at a later time. Thank you for being a supportive mentor. :)
Flags: needinfo?(ark.sadhu2904)
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.