Closed Bug 1218452 Opened 7 years ago Closed 7 years ago

Remove the spark distro from the Aries Engineering builds

Categories

(Taskcluster :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: u504868, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 1187330 was supposed to introduce engineering apps in the spark distro. It turned out to show a weird error, only on the TC job that builds mozilla-central for b2g-desktop. 

Bug 1196992 is showing good progress in order to make the spark apps available in the regular tree. Bugzilla Lite has already landed in the regular build, for instance. 

Hence, we can remove the spark distro argument in the Engineering builds for Aries. For the record, this was introduced in bug 1182116.

We don't want to change the user/userdebug builds for now. Some data migration scenarios need to be tested first. Engineering builds don't show this problem as data migration is not tested in automation.
Attached file git patch (obsolete) —
git patch; I probably need to make a hg patch instead.

wcosta, do you think going about this way is ok?  If so I'll change it to be a hg patch instead.  If you aren't the right person to ask for code review, can you forward it to the appropriate person please?
Flags: needinfo?(wcosta)
Attachment #8679749 - Flags: review?(wcosta)
Oh, I also forgot to remove spark from the name of the file.  Other than those points, is the method ok?
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #1)
> Created attachment 8679749 [details]
> git patch
> 
> git patch; I probably need to make a hg patch instead.
> 

I use the command "git bz attach" from moz-git-tools [1] for that. 

> wcosta, do you think going about this way is ok?  If so I'll change it to be
> a hg patch instead.  If you aren't the right person to ask for code review,
> can you forward it to the appropriate person please?

It looks good to me. One day we will need to make the build scripts more flexible so we don't need too many config files, but that's something for the future.
Flags: needinfo?(wcosta)
Attachment #8679749 - Flags: review?(wcosta) → review+
Comment on attachment 8680117 [details] [diff] [review]
Remove Spark from Engineering build

Oh snap!  Can you do a quick review again please?
Attachment #8680117 - Flags: review?(wcosta)
Comment on attachment 8680117 [details] [diff] [review]
Remove Spark from Engineering build

Review of attachment 8680117 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Could you please post a link to a successful build?
Attachment #8680117 - Flags: review?(wcosta) → review+
https://tools.taskcluster.net/task-inspector/#Pi3VMubOT1SoMrAGq8TcjA/0 was the successful build....
Did you want me to make a new build based on the new hg patch?
Flags: needinfo?(wcosta)
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #9)
> https://tools.taskcluster.net/task-inspector/#Pi3VMubOT1SoMrAGq8TcjA/0 was
> the successful build....
> Did you want me to make a new build based on the new hg patch?

No, it is fine for me.
Flags: needinfo?(wcosta)
seems this does not apply:

patching file testing/taskcluster/tasks/builds/b2g_aries_eng.yml
Hunk #1 FAILED at 10
1 out of 1 hunks FAILED -- saving rejects to file testing/taskcluster/tasks/builds/b2g_aries_eng.yml.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1218452-Remove-Spark-from-Engineering-build.patch
Flags: needinfo?(wcosta)
Naoki,

Could you please rebase your patch?
Flags: needinfo?(wcosta) → needinfo?(nhirata.bugzilla)
Rebased patch, released I also needed to change the tasks.
Attachment #8679749 - Attachment is obsolete: true
Attachment #8680117 - Attachment is obsolete: true
Flags: needinfo?(nhirata.bugzilla)
Can you re-review please?
Flags: needinfo?(wcosta)
Attachment #8683973 - Flags: review?(wcosta) → review+
Flags: needinfo?(wcosta)
https://hg.mozilla.org/mozilla-central/rev/661a1b6450a0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
I flashed the latest build under the namespace "gecko.v1.mozilla-central.latest.linux.aries-eng.opt". I got the engineering apps on it[2]. All the apps under apps/ and hosted_apps/ were also present.

In other words, that's exactly what is needed.

Thanks Naoki for you great help! 

[1] https://tools.taskcluster.net/task-inspector/#Epy_vB94T0eWIU0WoFaPRg/
[2] https://github.com/mozilla-b2g/gaia/blob/971df213c86811dce3370b2ff0d12f44041c9fe9/build/config/phone/apps-engineering.list
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.