1218453 - Shouldn't check for TALOSDATA if test failed for other reasons

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[William Lachance (:wlach)]

A likely rather serious and reproducible problem, bug 1205005, looks more like a harmless harness/mozharness issue because "no talosdata" is the topmost error message. Of course there's no talosdata if the harness crashes or times out. :)

Let's fix this.

Comment 1

[William Lachance (:wlach)]

Attachment: Only check for talosdata if harness exited ok

Comment 2

[William Lachance (:wlach)]

Two try runs:

(1) Testing the patch above: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6b8b0b40c22
(2) Testing the patch in (1) + intentional removal of TALOSDATA from output (to see if error's still triggered): https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ed102d3517e
(3) Testing the patch in (1) + intentional harness bustage before TALOSDATA printed (to make sure we don't see TALOSDATA if harness failed): https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f81f2c8555c

Comment 3

[Julien Pagès (:parkouss)]

Comment on attachment 8678943 [details] [diff] [review]
Only check for talosdata if harness exited ok

Looks good to me.

Comment 4

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #2)
> Two try runs:
> 
> (1) Testing the patch above:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6b8b0b40c22
> (2) Testing the patch in (1) + intentional removal of TALOSDATA from output
> (to see if error's still triggered):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ed102d3517e
> (3) Testing the patch in (1) + intentional harness bustage before TALOSDATA
> printed (to make sure we don't see TALOSDATA if harness failed):
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f81f2c8555c

Verified that all of these worked as expected.

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8678943 [details] [diff] [review]
Only check for talosdata if harness exited ok

Review of attachment 8678943 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm :)

Comment 6

[Carsten Book [:Tomcat]]

Hi, this doesn't apply to mozilla-inbound:

renamed 1218453 -> file_1218453.txt
applying file_1218453.txt
patching file testing/mozharness/mozharness/mozilla/testing/talos.py
Hunk #1 FAILED at 402
1 out of 1 hunks FAILED -- saving rejects to file testing/mozharness/mozharness/mozilla/testing/talos.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh file_1218453.txt

could you take a look, thanks!

Comment 7

[William Lachance (:wlach)]

Attachment: tpatch.patch

I believe the previous patch had windows line endings or something (can't even imagine why), try this one.

Comment 8

[William Lachance (:wlach)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f2f9f43f4df97ed3ce96ad8b5497f68e9d8225
Bug 1218453 - Only check for TALOSDATA if harness exited successfully;r=jlund

Comment 9

[William Lachance (:wlach)]

Checked this in myself ^^^

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b7f2f9f43f4d

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b7f2f9f43f4d

Comment 12

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8036c2f9c76d