Closed Bug 1218454 Opened 4 years ago Closed 4 years ago

clean up including nsContentUtils.h

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(4 files)

No description provided.
We used to need nsContentUtils.h here for nsCxPusher, but since that got
moved to ScriptSettings.h, we no longer need nsContentUtils.h for
anything.
Attachment #8678937 - Flags: review?(bzbarsky)
No reason for one ::Get to be out-of-line and the other not.  This
change means that nsGlobalWindow.h doesn't depend on nsContentUtils.
Attachment #8678938 - Flags: review?(bzbarsky)
There's no reason for this function to be declared in nsILoadContext's
class declaration.  A lot of fixups for nsContentUtils.h bootlegging are
necessary, however.
Attachment #8678939 - Flags: review?(bzbarsky)
Comment on attachment 8678937 [details] [diff] [review]
part 0 - don't #include nsContentUtils.h from CallbackObject.h

r=me
Attachment #8678937 - Flags: review?(bzbarsky) → review+
Comment on attachment 8678938 [details] [diff] [review]
part 1 - move DialogValueHolder::Get out-of-line

>+DialogValueHolder::Get(JSContext* aCx, JS::Handle<JSObject*> aScope, nsIPrincipal* aSubject,
>+           JS::MutableHandle<JS::Value> aResult, mozilla::ErrorResult& aError)

Fix indent.  And watch the 80 col limit?

r=me
Attachment #8678938 - Flags: review?(bzbarsky) → review+
Comment on attachment 8678939 [details] [diff] [review]
part 2 - move nsILoadContext::GetOriginAttributes out-of-line

r=me, but I expect all those additional #include bits should be in part 0, not here....  Otherwise I expect applying just part 0 does not compile.

Similarly, should part 1 be before part 0?
Attachment #8678939 - Flags: review?(bzbarsky) → review+
Depends on: 1229176
A few additional #include bootleggings turned up that didn't seem to fit into
the previous two patches.  Should be trivial to review.
Attachment #8694681 - Flags: review?(bzbarsky)
Comment on attachment 8694681 [details] [diff] [review]
part 2a - fix bootlegging of nsContentUtils.h includes from nsILoadContext.h

r=me
Attachment #8694681 - Flags: review?(bzbarsky) → review+
You need to log in before you can comment on or make changes to this bug.