1218455 - 'this' doesn't get autocompleted in console

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Brian Grinstead [:bgrins]]

STR:
Open console
Type 't'

Expected:
'this' is offered as a suggestion

Actual:
'this' is not offered as a suggestion

Comment 1

[Brian Grinstead [:bgrins]]

May as well block this on Bug 1217591, which is moving the autocompletion stuff into it's own file

Comment 2

[Brian Grinstead [:bgrins]]

Nick, the list is populated by the debugger api's getOwnPropertyNames: https://dxr.mozilla.org/mozilla-central/source/devtools/shared/webconsole/js-property-provider.js#485.  This doesn't return 'this' when getting the properties in an environment.

This may be technically right (I'm not sure), but for the user's sake I'd love if `this` was autocompleted, and subproperties on `this.` as well.  Any ideas how to tackle this?  Maybe it could be included from the debugger APIs, or we could to somehow shim it in the actor.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

`this` is not a property, it is its own special thing, so I don't think it belongs in `getOwnPropertyNames`.

Probably best to special case it in the property provider.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1218455 - Special case 'this' to include in console autocompletion;r=fitzgen

Bug 1218455 - Special case 'this' to include in console autocompletion;r=fitzgen

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8694492 [details]
MozReview Request: Bug 1218455 - Special case 'this' to include in console autocompletion;r=fitzgen

https://reviewboard.mozilla.org/r/26777/#review24293

LGTM, one small question below.

::: devtools/shared/webconsole/js-property-provider.js:500
(Diff revision 1)
> +    // Include 'this' in results for the global object (in sorted order)

This seems to be unconditionally adding "this" to the properties, regardless whether the given object is a global, which seems counter to what the comment describes. I would expect this loop to be guarded by some kind of global check.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] from comment #5)
> ::: devtools/shared/webconsole/js-property-provider.js:500
> (Diff revision 1)
> > +    // Include 'this' in results for the global object (in sorted order)
> 
> This seems to be unconditionally adding "this" to the properties, regardless
> whether the given object is a global, which seems counter to what the
> comment describes. I would expect this loop to be guarded by some kind of
> global check.

We discussed this and decided to remove the note in the comment about global objects, since 'this' is manually removed from non-globals later on.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4f704aecb249

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4f704aecb249

Comment 9

[Md. Ehsanul Hassan]

I have reproduced in Nightly 44.0a1 (2015-10-26) on windows 8.1(64 bit) from Comment #0.
Build Id:20151026030422
User Agent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0

This Bug is now verified as fixed on Latest Firefox developer edition 
Build ID: 20160115004002
User Agent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

Comment 10

[Bolaram Paul [:ancon]]

This Bug is now verified as fixed on Latest Firefox 45.0 Beta 3 

User Agent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0