1218488 - clarify buffer ownership for nsICanvasRenderingContextInternal::GetBuffer

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nathan Froyd [:froydnj]]

This patch started life as making ImageEncoder.cpp:EncodingRunnable not
use nsAutoArrayPtr, but the API effects rippled out from there.  On the
whole, I think using UniquePtr throughout has made the code clearer.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: clarify buffer ownership for nsICanvasRenderingContextInternal::GetBuffer

Bas for the gfx/ parts (and the Windows widget parts, if he feels comfortable
with them), baku for the dom/ parts.

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8679014 [details] [diff] [review]
clarify buffer ownership for nsICanvasRenderingContextInternal::GetBuffer

Review of attachment 8679014 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/CanvasRenderingContextHelper.cpp
@@ +49,5 @@
>        return;
>      }
>    }
>  
> +  UniquePtr<uint8_t[]> imageBuffer = nullptr;

remove '= nullptr'

::: dom/canvas/WebGLContext.cpp
@@ +1061,5 @@
>      bool premult;
>      RefPtr<SourceSurface> snapshot =
>        GetSurfaceSnapshot(mOptions.premultipliedAlpha ? nullptr : &premult);
>      if (!snapshot)
> +        return nullptr;

if (!snapshot) {
  return;
}

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8679014 [details] [diff] [review]
clarify buffer ownership for nsICanvasRenderingContextInternal::GetBuffer

Review of attachment 8679014 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContext.cpp
@@ +1061,5 @@
>      bool premult;
>      RefPtr<SourceSurface> snapshot =
>        GetSurfaceSnapshot(mOptions.premultipliedAlpha ? nullptr : &premult);
>      if (!snapshot)
> +        return nullptr;

Wait.. what? You can't return nothing from this function.. can you?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53952bbfad9a

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/53952bbfad9a