1218542 - Fix TC linux64 xpcshell system encoding failure

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

See:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b84d34d7166a&filter-searchStr=xpcshell

and ted's suggestion:
https://bugzilla.mozilla.org/show_bug.cgi?id=1171033#c24

Comment 1

[Andrew Halberstadt [:ahal]]

Adding LANG=en_US.UTF-8 didn't seem to make a difference:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd91d26b8871

Comment 2

[Andrew Halberstadt [:ahal]]

Here's a clue in the log:
21:40:32     INFO -  PROCESS | 3022 | (process:3022): Gtk-WARNING **: Locale not supported by C library.
21:40:32     INFO -  PROCESS | 3022 | 	Using the fallback 'C' locale.

Which after some googling lead to:
http://askubuntu.com/a/359932

So it seems the language pack may need to be installed in the image, and we may need to run 'dpkg-reconfigure locales' to set it up.

Comment 3

[Andrew Halberstadt [:ahal]]

Some success:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e01926a462c8

We needed the 'language-pack-en-base' package installed, then set LANG. Chunk 2 still fails for other reasons though. Will post some patches later today.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1218542 - Install language-pack-en-base in ubuntu1204-test image; set LANG/LC_ALL to en_US.UTF-8, r=dustin

Bug 1218542 - Install language-pack-en-base in ubuntu1204-test image, r=dustin

Also calls `dpkg-reconfigure locales`, but it's not entirely clear if this is
necessary or not.

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1218542 - Set LANG and LC_ALL to en_US.UTF-8 for desktop taskcluster tests, r=dustin

Bug 1218542 - Set LANG and LC_ALL to en_US.UTF-8 for desktop taskcluster tests, r=dustin

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8681985 [details]
MozReview Request: Bug 1218542 - Install language-pack-en-base in ubuntu1204-test image; set LANG/LC_ALL to en_US.UTF-8, r=dustin

https://reviewboard.mozilla.org/r/23931/#review21367

::: testing/docker/ubuntu1204-test-upd/VERSION:1
(Diff revision 1)
> -0.1.1.20151012044301
> +0.1.2

This should remain a datestamp.  At some point, we'll have an autolander bumping it, and the date gives a good indication of when the image was created (the FROM in desktop-test should be changed, too)

Looks good otherwise.  Do you have permission to push these images, or do you want me to build and push the results?  Greg's working on automatically building images now :)

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8681986 [details]
MozReview Request: Bug 1218542 - Set LANG and LC_ALL to en_US.UTF-8 for desktop taskcluster tests, r=dustin

https://reviewboard.mozilla.org/r/23933/#review21369

::: testing/taskcluster/tasks/tests/fx_unittest_base.yml:21
(Diff revision 1)
> +      LC_ALL: 'en_US.UTF-8'

I wonder if it would be better to specify these at the system level somehow?  Maybe in /etc/profile.d?

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8681985 [details]
MozReview Request: Bug 1218542 - Install language-pack-en-base in ubuntu1204-test image; set LANG/LC_ALL to en_US.UTF-8, r=dustin

Bug 1218542 - Install language-pack-en-base in ubuntu1204-test image; set LANG/LC_ALL to en_US.UTF-8, r=dustin

Also calls `dpkg-reconfigure locales`, but it's not entirely clear if this is
necessary or not.

Comment 9

[Andrew Halberstadt [:ahal]]

> Looks good otherwise.  Do you have permission to push these images, or do
> you want me to build and push the results?  Greg's working on automatically
> building images now :)

I don't think I have permission to push these.. I don't mind doing it if you give me permission, otherwise, yes please push them on my behalf :).

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8681985 [details]
MozReview Request: Bug 1218542 - Install language-pack-en-base in ubuntu1204-test image; set LANG/LC_ALL to en_US.UTF-8, r=dustin

https://reviewboard.mozilla.org/r/23931/#review21375

Thanks!

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Builds in progress

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Builds complete -- you should be good to land this.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b083ca57314a

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b083ca57314a

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b083ca57314a

Comment 16

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion