Closed Bug 1218559 Opened 4 years ago Closed 4 years ago

Implement FindUniformBlockByMappedName

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

No description provided.
Attachment #8679082 - Flags: review?(jgilbert)
Attachment #8679082 - Attachment is patch: true
Assignee: nobody → jmuizelaar
Whiteboard: [gfx-noted]
Blocks: 1215279
Comment on attachment 8679082 [details] [diff] [review]
Implement FindUniformBlockByMappedName

Review of attachment 8679082 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLShaderValidator.cpp
@@ +385,5 @@
> +ShaderValidator::FindUniformBlockByMappedName(const std::string& mappedName,
> +                                              std::string* const out_userName) const
> +{
> +    const std::vector<sh::InterfaceBlock>& interfaces = *ShGetInterfaceBlocks(mHandle);
> +    for (const auto &interface : interfaces) {

const auto& interface
Attachment #8679082 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/13c39f24d52f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.