Closed
Bug 1218591
Opened 8 years ago
Closed 8 years ago
Reset the WebSocket retry counter when the server replies
Categories
(Core :: DOM: Push Notifications, defect)
Core
DOM: Push Notifications
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
Details
Attachments
(1 file)
6.20 KB,
patch
|
dragana
:
review+
|
Details | Diff | Splinter Review |
Currently, we reset the retry counter when the WebSocket connection succeeds. I think we should wait until the first response from the Push server. This ensures the client won't endlessly retry with a zero-delay if the handshake fails (e.g., https://github.com/mozilla-services/autopush/issues/151).
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8679135 -
Flags: review?(bbangert)
Assignee | ||
Updated•8 years ago
|
Attachment #8679135 -
Flags: review?(bbangert) → review?(dd.mozilla)
Updated•8 years ago
|
Attachment #8679135 -
Flags: review?(dd.mozilla) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/820fa1592bfa156281023a22e8aab04196117452 Bug 1218591 - Reset the WebSocket retry counter when the server replies. r=dragana
Comment 3•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/820fa1592bfa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•