Closed Bug 1218591 Opened 8 years ago Closed 8 years ago

Reset the WebSocket retry counter when the server replies

Categories

(Core :: DOM: Push Notifications, defect)

Product:
Core
Component:
DOM: Push Notifications
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

Attachments

(1 file)

0001-Bug-1218591-Reset-the-WebSocket-retry-counter-when-t.patch
6.20 KB, patch
dragana
: review+
Details | Diff | Splinter Review 
Currently, we reset the retry counter when the WebSocket connection succeeds. I think we should wait until the first response from the Push server. This ensures the client won't endlessly retry with a zero-delay if the handshake fails (e.g., https://github.com/mozilla-services/autopush/issues/151).
Attachment #8679135 - Flags: review?(bbangert) → review?(dd.mozilla)
Attachment #8679135 - Flags: review?(dd.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/820fa1592bfa156281023a22e8aab04196117452
Bug 1218591 - Reset the WebSocket retry counter when the server replies. r=dragana
https://hg.mozilla.org/mozilla-central/rev/820fa1592bfa
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.