Closed
Bug 1218641
Opened 9 years ago
Closed 9 years ago
IonMonkey: MIPS64: Add support into asmjs
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
References
Details
Attachments
(1 file)
21.25 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
Bug 1140954, Part 20: Add support into asmjs.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8679241 -
Flags: review?(lhansen)
Comment 2•9 years ago
|
||
Comment on attachment 8679241 [details] [diff] [review] 0001-IonMonkey-MIPS64-Add-support-into-asmjs.patch Review of attachment 8679241 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/asmjs/AsmJSFrameIterator.cpp @@ +579,2 @@ > if (offsetInCodeRange < PushedRetAddr) { > + // First instruction of the ARM/MIPS/MIPS64 function; the return address is Comment too long (max=80) @@ +582,5 @@ > callerPC_ = state.lr; > callerFP_ = fp; > AssertMatchesCallSite(*module_, codeRange, callerPC_, callerFP_, sp - 2); > } else if (offsetInModule == codeRange->profilingReturn() - PostStorePrePopFP) { > + // Second-to-last instruction of the ARM/MIPS/MIPS64 function; fp points to Comment too long (max=80)
Attachment #8679241 -
Flags: review?(lhansen) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d7ec69d2896d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•