1218708 - Rocketbar should have the same size in all the apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Alberto Pastor [:albertopq]]

Compare the url bar size in browser and any other app (Facebook, for example). The size is bigger in the latter. It should be the same.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

I remember Eric saying that the rocketbar should have the same size in all apps [1] and it seems there is still legacy code that doesn't follow that spec (and that doesn't work with the new statusbar).

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1178696#c6

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

Excellent, nice to see this getting fixed. Not sure why we had it after all this time.

There is a bug here. On the homescreen, the search input does not take up the entire screen anymore, so there is a weird looking gap to the right.

Comment 4

[Alberto Pastor [:albertopq]]

Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

At the end, it was there for a reason (almost always is in that way :P) but it only should apply when is maximized. Minimized rocketbars should have the same size in all cases, as we don't have buttons.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

LGTM, thanks!

Comment 6

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/44aef5f1f9fa58963db9b5f36851881c7e92f227