Rocketbar should have the same size in all the apps

RESOLVED FIXED

Status

Firefox OS
Gaia::System::Status bar, Utility tray, Notification
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: albertopq, Assigned: albertopq)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Compare the url bar size in browser and any other app (Facebook, for example). The size is bigger in the latter. It should be the same.
(Assignee)

Updated

2 years ago
Assignee: nobody → apastor

Comment 1

2 years ago
Created attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

I remember Eric saying that the rocketbar should have the same size in all apps [1] and it seems there is still legacy code that doesn't follow that spec (and that doesn't work with the new statusbar).

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1178696#c6
Attachment #8679340 - Flags: review?(mhenretty)
Whiteboard: [systemsfe]
Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

Excellent, nice to see this getting fixed. Not sure why we had it after all this time.

There is a bug here. On the homescreen, the search input does not take up the entire screen anymore, so there is a weird looking gap to the right.
Attachment #8679340 - Flags: review?(mhenretty)
(Assignee)

Comment 4

2 years ago
Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

At the end, it was there for a reason (almost always is in that way :P) but it only should apply when is maximized. Minimized rocketbars should have the same size in all cases, as we don't have buttons.
Attachment #8679340 - Flags: review?(mhenretty)
Comment on attachment 8679340 [details] [review]
[gaia] albertopq:1218708-urlbar-size > mozilla-b2g:master

LGTM, thanks!
Attachment #8679340 - Flags: review?(mhenretty) → review+
(Assignee)

Comment 6

2 years ago
master: https://github.com/mozilla-b2g/gaia/commit/44aef5f1f9fa58963db9b5f36851881c7e92f227
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.