Closed Bug 1218763 Opened 4 years ago Closed 4 years ago

Antivirus should retry on SSLError

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(firefox42 fixed, firefox43 fixed, firefox-esr38 fixed, b2g-master fixed)

RESOLVED FIXED
Tracking Status
firefox42 --- fixed
firefox43 --- fixed
firefox-esr38 --- fixed
b2g-master --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch SSLError.diff (obsolete) — Splinter Review
04:56:18     INFO - Downloading pub/firefox/candidates/42.0-candidates/build1/update/win32/fa/firefox-40.0.3-42.0.partial.mar to cache/update/win32/fa/firefox-40.0.3-42.0.partial.mar
04:56:18    FATAL - Uncaught exception: Traceback (most recent call last):
04:56:18    FATAL -   File "/builds/slave/rel-m-rel-av-00000000000000000/scripts/mozharness/base/script.py", line 1698, in run
04:56:18    FATAL -     self.run_action(action)
04:56:18    FATAL -   File "/builds/slave/rel-m-rel-av-00000000000000000/scripts/mozharness/base/script.py", line 1640, in run_action
04:56:18    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
04:56:18    FATAL -   File "/builds/slave/rel-m-rel-av-00000000000000000/scripts/mozharness/base/script.py", line 1581, in _possibly_run_method
04:56:18    FATAL -     return getattr(self, method_name)()
04:56:18    FATAL -   File "scripts/scripts/release/antivirus.py", line 175, in get_files
04:56:18    FATAL -     pool.map(worker, find_release_files())
04:56:18    FATAL -   File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 227, in map
04:56:18    FATAL -     return self.map_async(func, iterable, chunksize).get()
04:56:18    FATAL -   File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 528, in get
04:56:18    FATAL -     raise self._value
04:56:18    FATAL - SSLError: The read operation timed out
04:56:18    FATAL - Running post_fatal callback...
04:56:18    FATAL - Exiting -1
Attachment #8679417 - Flags: review?(nthomas)
Assignee: nobody → rail
Attached patch IOError.diffSplinter Review
This is a more generic one. IOError includes SSLError:

SSLError.mro()
[ssl.SSLError,
 socket.error,
 IOError,
 EnvironmentError,
 StandardError,
 Exception,
 BaseException,
 object]
Attachment #8679487 - Flags: review?(nthomas)
Attachment #8679417 - Attachment is obsolete: true
Attachment #8679417 - Flags: review?(nthomas)
Attachment #8679487 - Flags: review?(nthomas) → review+
Keywords: leave-open
More errors:

22:16:27     INFO - Downloading pub/firefox/candidates/38.4.0esr-candidates/build2/update/win32/as/firefox-38.4.0esr.complete.mar to cache/update/win32/as/firefox-38.4.0esr.complete.mar
22:16:27    FATAL - Uncaught exception: Traceback (most recent call last):
22:16:27    FATAL -   File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1693, in run
22:16:27    FATAL -     self.run_action(action)
22:16:27    FATAL -   File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1635, in run_action
22:16:27    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
22:16:27    FATAL -   File "/builds/slave/rel-m-esr38-av-000000000000000/scripts/mozharness/base/script.py", line 1576, in _possibly_run_method
22:16:27    FATAL -     return getattr(self, method_name)()
22:16:27    FATAL -   File "scripts/scripts/release/antivirus.py", line 176, in get_files
22:16:27    FATAL -     pool.map(worker, find_release_files())
22:16:27    FATAL -   File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 227, in map
22:16:27    FATAL -     return self.map_async(func, iterable, chunksize).get()
22:16:27    FATAL -   File "/tools/python27/lib/python2.7/multiprocessing/pool.py", line 528, in get
22:16:27    FATAL -     raise self._value
22:16:27    FATAL - IncompleteRead: IncompleteRead(0 bytes read, 69074905 more expected)
22:16:27    FATAL - Running post_fatal callback...
22:16:27    FATAL - Exiting -1
httplib.IncompleteRead.__mro__

(httplib.IncompleteRead,
 httplib.HTTPException,
 Exception,
 BaseException,
 object)
Attachment #8679974 - Flags: review?(nthomas)
Attachment #8679974 - Flags: review?(nthomas) → review+
Attachment #8679487 - Flags: checked-in+
Comment on attachment 8679487 [details] [diff] [review]
IOError.diff

I'd like to land this patch to the release branches (it's already in aurora). It doesn't affect the product and used only by Releng to run antivirus checks as a part of release automation.
Attachment #8679487 - Flags: approval-mozilla-release?
Attachment #8679487 - Flags: approval-mozilla-esr38?
Attachment #8679487 - Flags: approval-mozilla-beta?
Comment on attachment 8679974 [details] [diff] [review]
HTTPException.diff

I'd like to land this patch to the release branches (it's already in aurora). It doesn't affect the product and used only by Releng to run antivirus checks as a part of release automation.
Attachment #8679974 - Flags: approval-mozilla-release?
Attachment #8679974 - Flags: approval-mozilla-esr38?
Attachment #8679974 - Flags: approval-mozilla-beta?
Comment on attachment 8679487 [details] [diff] [review]
IOError.diff

Approved for uplift to beta, release, and esr38; we need this for the build process
Attachment #8679487 - Flags: approval-mozilla-release?
Attachment #8679487 - Flags: approval-mozilla-release+
Attachment #8679487 - Flags: approval-mozilla-esr38?
Attachment #8679487 - Flags: approval-mozilla-esr38+
Attachment #8679487 - Flags: approval-mozilla-beta?
Attachment #8679487 - Flags: approval-mozilla-beta+
Comment on attachment 8679974 [details] [diff] [review]
HTTPException.diff

Approved to land on beta, release, esr38
Attachment #8679974 - Flags: approval-mozilla-release?
Attachment #8679974 - Flags: approval-mozilla-release+
Attachment #8679974 - Flags: approval-mozilla-esr38?
Attachment #8679974 - Flags: approval-mozilla-esr38+
Attachment #8679974 - Flags: approval-mozilla-beta?
Attachment #8679974 - Flags: approval-mozilla-beta+
Thanks!
and ESR38:
https://hg.mozilla.org/releases/mozilla-esr38/rev/12d999e5fe3b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.