Closed Bug 1218780 Opened 9 years ago Closed 9 years ago

Notifications shouldn't use a hand cursor

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: phlsa, Assigned: jaws)

References

Details

Attachments

(1 file)

Patch
707 bytes, patch
MattN
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
When moving the mouse over a notification, the cursor should remain the default arrow cursor.
Flags: needinfo?(jaws)
Attached patch Patch — — Splinter Review 
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)

        Attachment #8679446 -
        Flags: review?(MattN+bmo)
Component: DOM: Push Notifications → Themes
Product: Core → Toolkit

    
  

        Attachment #8679446 -
        Flags: review?(MattN+bmo) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/302277d37f39
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

    
    

    
  
Comment on attachment 8679446 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Notification improvements in Fx44
[User impact if declined]: Hand cursor appears on notifications which doesn't match most platform conventions
[Describe test coverage new/current, TreeHerder]: m-c
[Risks and why]: Trivial, low risk
[String/UUID change made/needed]: None

        Attachment #8679446 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8679446 [details] [diff] [review]
Patch

Seems like a low risk fix, let's uplift to Aurora44.

        Attachment #8679446 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
I just noticed (from comment 5) that this was uplifted to Aurora44 already. Comment 6 doesn't mean much except a rubber stamp. :)

    
    

    
  
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

          status-b2g-v2.5:
          fixed → ---

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: