use fallible allocations in Downscaler.cpp

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
MakeUnique and its underlying |new| call will crash the program on
failure.  This code was clearly written with fallible allocations in
mind, so let's make the allocations actually be fallible.
(Assignee)

Comment 1

3 years ago
Created attachment 8679437 [details] [diff] [review]
use fallible allocations in Downscaler.cpp
Attachment #8679437 - Flags: review?(seth)
(Assignee)

Comment 2

3 years ago
Created attachment 8679439 [details] [diff] [review]
use fallible allocations in Downscaler.cpp

Here, let's actually refresh HEAD so you can review a patch which compiles.
Attachment #8679439 - Flags: review?(seth)
(Assignee)

Updated

3 years ago
Attachment #8679437 - Attachment is obsolete: true
Attachment #8679437 - Flags: review?(seth)
Comment on attachment 8679439 [details] [diff] [review]
use fallible allocations in Downscaler.cpp

Review of attachment 8679439 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this. It has been on my TODO list for a long time, but I never got around to it.
Attachment #8679439 - Flags: review?(seth) → review+
https://hg.mozilla.org/mozilla-central/rev/0395c8b2846b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.