1218782 - use fallible allocations in Downscaler.cpp

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Nathan Froyd [:froydnj]]

MakeUnique and its underlying |new| call will crash the program on
failure.  This code was clearly written with fallible allocations in
mind, so let's make the allocations actually be fallible.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use fallible allocations in Downscaler.cpp

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: use fallible allocations in Downscaler.cpp

Here, let's actually refresh HEAD so you can review a patch which compiles.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8679439 [details] [diff] [review]
use fallible allocations in Downscaler.cpp

Review of attachment 8679439 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this. It has been on my TODO list for a long time, but I never got around to it.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0395c8b2846b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0395c8b2846b