Closed Bug 1218782 Opened 8 years ago Closed 8 years ago

use fallible allocations in Downscaler.cpp

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

use fallible allocations in Downscaler.cpp
2.21 KB, patch
seth
: review+
Details | Diff | Splinter Review 
MakeUnique and its underlying |new| call will crash the program on
failure.  This code was clearly written with fallible allocations in
mind, so let's make the allocations actually be fallible.

        Attachment #8679437 -
        Flags: review?(seth)

    
    

    
  


  
Here, let's actually refresh HEAD so you can review a patch which compiles.

        Attachment #8679439 -
        Flags: review?(seth)

    
  

        Attachment #8679437 -
        Attachment is obsolete: true

        Attachment #8679437 -
        Flags: review?(seth)

    
    

    
  
Comment on attachment 8679439 [details] [diff] [review]
use fallible allocations in Downscaler.cpp

Review of attachment 8679439 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this. It has been on my TODO list for a long time, but I never got around to it.

        Attachment #8679439 -
        Flags: review?(seth) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0395c8b2846b
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

          You need to log in
          before you can comment on or make changes to this bug.