1218808 - [ruleview] edit to element style doesn't work correctly

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Tom Tromey :tromey]

This is a regression introduced by as-authored.

Inspect any element with the rule view.
Add a "background-color" property to the element and apply it.
Now, edit it to be a "color" property instead.

Note that the background color did not change.
Click on some other element and then back to the original element,
and you'll see both background-color and color properties.

Instead, editing the property name should cause the old property
to be removed.

Comment 1

[Tom Tromey :tromey]

Attachment: make renaming a property on an element work

This was just a small thinko in setPropertyName.

Comment 2

[Tom Tromey :tromey]

Attachment: make renaming a property on an element work

git add the test

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8679656 [details] [diff] [review]
make renaming a property on an element work

Review of attachment 8679656 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great to me. Thanks for catching this regression. Let's try to get it in time for 44 (uplift is today, but it's small regression fix anyway, so we can easily get approval for uplift later if it doesn't make it)

Comment 4

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8abcca35de5a

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4b8c70ee14ed

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8679656 [details] [diff] [review]
make renaming a property on an element work

Approval Request Comment
[Feature/regressing bug #]:
This is a regression introduced by bug 984880, which implemented
a new devtools feature ("as-authored styles")
[User impact if declined]:
If the user uses the rule view to rename a property, the old property
will not be removed, causing confusion.
[Describe test coverage new/current, TreeHerder]:
New test case covering the new code.
[Risks and why]: 
Low risk; first it is a reasonably obvious thinko in the code; and second
there is a test case covering the new behavior.
[String/UUID change made/needed]: No.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4b8c70ee14ed

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8679656 [details] [diff] [review]
make renaming a property on an element work

Patch seems simple enough and has new tests. Seems safe to uplift to Aurora44.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4b8c70ee14ed

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1e78c8aebe65

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/1e78c8aebe65