1218844 - Fix apps/system/regions/status_bar.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

+++ This bug was initially created as a clone of Bug #1179723 +++

Due to the bug 1179723, the StatusBar class methods return incorrect value.  For example, when in a fullscreen app, it reports the status bar is being displayed while there isn't.  For example, in case of fullscreen app, it appears that one needs to check the screen element for it to set its name to 'fullscreen-app minimized-tray' when the status bar is being displayed.

Comment 1

[Alberto Pastor [:albertopq]]

Sorry about that. Note that we are moving the statusbar out of the viewport, so probably the tests need to do something as we did in the Gij ones:

https://github.com/mozilla-b2g/gaia/commit/17fd5bd7a909a0bbecf672f3027add75565078ab#diff-3bcfdb8ced809559fa10c1c40223e77dR70

Let me know how can I help for fixing them. Thanks!

Comment 2

[Martijn Wargers (dead)]

I just checked in the fix for bug 1217870. Not sure how much that helps here.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1218844 > mozilla-b2g:master

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8679596 [details] [review]
[gaia] npark-mozilla:1218844 > mozilla-b2g:master

This simple fix seems to cover the fullscreen app cases, while existing test cases are still passing.

Comment 5

[No-Jun Park [:njpark]]

(In reply to Alberto Pastor [:albertopq] from comment #1)
> Sorry about that. Note that we are moving the statusbar out of the viewport,
> so probably the tests need to do something as we did in the Gij ones:
> 
> https://github.com/mozilla-b2g/gaia/commit/
> 17fd5bd7a909a0bbecf672f3027add75565078ab#diff-
> 3bcfdb8ced809559fa10c1c40223e77dR70
> 
> Let me know how can I help for fixing them. Thanks!

Aha, thanks for the tip, I saw your comment after I filed my PR. maybe your way is more robust.

Comment 6

[Martijn Wargers (dead)]

Comment on attachment 8679596 [details] [review]
[gaia] npark-mozilla:1218844 > mozilla-b2g:master

I think it can be made a little bit simpler, but it looks good for the rest.

I thought that elements out of the viewport return False for element.is_displayed(), but apparently that's not the case?
Or is the statusbar still partly visible?

Comment 7

[Johan Lorenzo [:jlorenzo] - PTO - Back August 24th]

Comment on attachment 8679596 [details] [review]
[gaia] npark-mozilla:1218844 > mozilla-b2g:master

Looks goot to me, modulo the small indentation nit.

Comment 8

[No-Jun Park [:njpark]]

All comments incorporated, and Merged:

https://github.com/mozilla-b2g/gaia/commit/453948536f33d93a2119231368097dc998904f32